New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 872905 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Password field should automatically have cursor focus when attempting to connected to password-protected Wi-Fi network

Project Member Reported by jessejames@chromium.org, Aug 9

Issue description

Chrome Version: 68.0.3440.76 beta
OS: crOS

What steps will reproduce the problem?
(1) Connect to new password-protected WiFi network
(2) Receive "Join Wi-Fi network" page

What is the expected result?
Password field has keyboard focus by default

What happens instead?
Password field does not have keyboard focus

This issue occurred on a Nami device, but was not reproducible on Eve

User feedback report:
https://listnr.corp.google.com/report/85592024671
 
Cc: tbarzic@chromium.org
Labels: -Pri-3 RegressedIn-68 Pri-2
Status: Assigned (was: Untriaged)
This used to work...

Labels: M-69
Status: Started (was: Assigned)
cr-input changed from using 'disabled' to 'readonly'; need to change the selector in the JS.

Cc: steve...@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 857440  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f853524ed338d0d78400d9da16ca63eae1fd119f

commit f853524ed338d0d78400d9da16ca63eae1fd119f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Aug 16 02:57:54 2018

Network config: Correctly select cr-input

Bug:  872905 
Change-Id: I86cedf0cb9eedf8d32f7385eba3a3c85b42a35a8
Reviewed-on: https://chromium-review.googlesource.com/1176430
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583513}
[modify] https://crrev.com/f853524ed338d0d78400d9da16ca63eae1fd119f/ui/webui/resources/cr_components/chromeos/network/network_config.js

Labels: Merge-Request-69
This is a very minor, isolated, and safe fix for a fairly annoying bug, requesting a merge to 69.

Project Member

Comment 7 by sheriffbot@chromium.org, Aug 17

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Mergea approved, M69.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e565430d0efe92a1a2e2b72d291367db37531a82

commit e565430d0efe92a1a2e2b72d291367db37531a82
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Aug 17 17:43:51 2018

Network config: Correctly select cr-input

TBR=stevenjb@chromium.org

(cherry picked from commit f853524ed338d0d78400d9da16ca63eae1fd119f)

Bug:  872905 
Change-Id: I86cedf0cb9eedf8d32f7385eba3a3c85b42a35a8
Reviewed-on: https://chromium-review.googlesource.com/1176430
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#583513}
Reviewed-on: https://chromium-review.googlesource.com/1180082
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#686}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/e565430d0efe92a1a2e2b72d291367db37531a82/ui/webui/resources/cr_components/chromeos/network/network_config.js

Status: Fixed (was: Started)

Sign in to add a comment