New issue
Advanced search Search tips

Issue 872903 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

Handle pages being added and removed while document is opened in PDF viewer

Project Member Reported by hnakashima@chromium.org, Aug 9

Issue description

To repro the page removal issue, on an XFA-enabled build:

1. Open the attached PageEvent.pdf
2. Click the button to remove a page.
Expected: The second page of the document disappears.
Actual: The second page of the document is still there.

To repro the page addition issue, on an XFA-enabled build:

1. Open the attached imm5257e_debug_add_page.qpdf
2. Click the Validate button to add a page.
Expected: The document grows from 5 to 6 pages, with the new sixth page containing barcodes.
Actual: Nothing happens.
 
PageEvent.pdf
78.2 KB Download
imm5257e_debug_add_page.qpdf
2.1 MB Download
Blocking: 872907
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cb6b59e39bce4769dfda830cf435b4400086ffd

commit 0cb6b59e39bce4769dfda830cf435b4400086ffd
Author: Henrique Nakashima <hnakashima@chromium.org>
Date: Mon Aug 20 18:46:15 2018

Handle FFI_PageEvent from PDFium in PDF Viewer.

Add or remove pages from the viewer in response to these events.

Bug:  pdfium:401 , chromium:872903 ,chromium:867135
Change-Id: Iddc88c5a90370213619a0f3f2587f215d0dafbc8
Reviewed-on: https://chromium-review.googlesource.com/1169691
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584515}
[modify] https://crrev.com/0cb6b59e39bce4769dfda830cf435b4400086ffd/pdf/pdfium/pdfium_engine.cc
[modify] https://crrev.com/0cb6b59e39bce4769dfda830cf435b4400086ffd/pdf/pdfium/pdfium_engine.h
[modify] https://crrev.com/0cb6b59e39bce4769dfda830cf435b4400086ffd/pdf/pdfium/pdfium_form_filler.cc
[modify] https://crrev.com/0cb6b59e39bce4769dfda830cf435b4400086ffd/pdf/pdfium/pdfium_form_filler.h

Status: Fixed (was: Started)

Sign in to add a comment