New issue
Advanced search Search tips

Issue 872890 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Migrate chromeos/timezone/timezone_request.cc using SimpleURLLoader

Project Member Reported by dxie@google.com, Aug 9

Issue description


 
Labels: Proj-Servicification Proj-Servicification-VendorBug Hotlist-KnownIssue
Labels: OS-Chrome
Status: Assigned (was: Available)
Taking this
Owner: svil...@igalia.com
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a1ed478415944ac54d326917f1cc4b5b594dba2

commit 5a1ed478415944ac54d326917f1cc4b5b594dba2
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Aug 21 19:26:40 2018

[chromeos] Migrate timezone/ & geolocation/ to SimpleURLLoader

Both are currently using URLFetcher for timezone and geolocation
requests. They should use SimpleURLLoader instead to make them
eventually work with the network service.

Instead of having different CLs for them, we're migrating them at the
same time as they're entangled, there is a dependency of geolocation
in the timezone code.

Bug:  872890 
Change-Id: I8180a774f9fd8eaca8406328f404fb216b13180e
Reviewed-on: https://chromium-review.googlesource.com/1177399
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584877}
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/browser_process_platform_part_chromeos.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/chromeos/login/wizard_controller.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/chromeos/night_light/night_light_client.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/chromeos/night_light/night_light_client.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/chromeos/night_light/night_light_client_unittest.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/chromeos/system/timezone_resolver_manager.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/geolocation/simple_geolocation_provider.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/geolocation/simple_geolocation_provider.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/geolocation/simple_geolocation_request.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/geolocation/simple_geolocation_request.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/geolocation/simple_geolocation_unittest.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/timezone/timezone_provider.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/timezone/timezone_provider.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/timezone/timezone_request.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/timezone/timezone_request.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/timezone/timezone_resolver.cc
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/timezone/timezone_resolver.h
[modify] https://crrev.com/5a1ed478415944ac54d326917f1cc4b5b594dba2/chromeos/timezone/timezone_unittest.cc

Status: Fixed (was: Assigned)
closing...

Sign in to add a comment