New issue
Advanced search Search tips

Issue 872878 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 5
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

Migrate chrome/browser/android/logo_bridge.cc using SimpleURLLoader

Project Member Reported by dxie@google.com, Aug 9

Issue description


 
Labels: Proj-Servicification Proj-Servicification-VendorBug Hotlist-KnownIssue
Labels: OS-Android
Labels: Proj-Servicification-Network-Url
 Issue 879780  has been merged into this issue.
Owner: svil...@igalia.com
Status: Assigned (was: Available)
Taking this...
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c

commit 1fb40c33efb87ab13d3cfa075a108f9c713a4c7c
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Sep 04 15:48:25 2018

[android] Migrate chrome/browser/android/logo_bridge.cc using SimpleURLLoader

It's currently using URLFetcher. It should use SimpleURLLoader
instead to make it eventually work with the network service.

Bug:  872878 
Change-Id: I4e170cfc75febb512e35783b488071014b21d7b2
Reviewed-on: https://chromium-review.googlesource.com/1203910
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588523}
[modify] https://crrev.com/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c/chrome/browser/android/logo_bridge.cc
[modify] https://crrev.com/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c/chrome/browser/android/logo_bridge.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c

commit 1fb40c33efb87ab13d3cfa075a108f9c713a4c7c
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Sep 04 15:48:25 2018

[android] Migrate chrome/browser/android/logo_bridge.cc using SimpleURLLoader

It's currently using URLFetcher. It should use SimpleURLLoader
instead to make it eventually work with the network service.

Bug:  872878 
Change-Id: I4e170cfc75febb512e35783b488071014b21d7b2
Reviewed-on: https://chromium-review.googlesource.com/1203910
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588523}
[modify] https://crrev.com/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c/chrome/browser/android/logo_bridge.cc
[modify] https://crrev.com/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c/chrome/browser/android/logo_bridge.h

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c

commit 1fb40c33efb87ab13d3cfa075a108f9c713a4c7c
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Sep 04 15:48:25 2018

[android] Migrate chrome/browser/android/logo_bridge.cc using SimpleURLLoader

It's currently using URLFetcher. It should use SimpleURLLoader
instead to make it eventually work with the network service.

Bug:  872878 
Change-Id: I4e170cfc75febb512e35783b488071014b21d7b2
Reviewed-on: https://chromium-review.googlesource.com/1203910
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588523}
[modify] https://crrev.com/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c/chrome/browser/android/logo_bridge.cc
[modify] https://crrev.com/1fb40c33efb87ab13d3cfa075a108f9c713a4c7c/chrome/browser/android/logo_bridge.h

Status: Fixed (was: Assigned)
Closing...

Sign in to add a comment