New issue
Advanced search Search tips

Issue 872877 link

Starred by 3 users
Status: Fixed
Owner:
svil...@igalia.com
Closed: Sep 5
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

Migrate chrome/browser/android/feedback/connectivity_checker.cc using SimpleURLLoader

Project Member Reported by dxie@google.com, Aug 9

Comment 1 by dxie@chromium.org, Aug 9

Labels: Proj-Servicification Proj-Servicification-VendorBug Hotlist-KnownIssue

Comment 2 by dxie@google.com, Aug 9

Labels: OS-Android

Comment 3 by dougt@chromium.org, Aug 22

Labels: Proj-Servicification-Network-Url

Comment 4 by svil...@igalia.com, Sep 4

Owner: svil...@igalia.com
Status: Assigned (was: Available)
Taking this...
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c02a65340b9fc1a787763c0c9744b47c265fd8c

commit 8c02a65340b9fc1a787763c0c9744b47c265fd8c
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Sep 04 15:37:18 2018

[android] Migrate connectivity_checker.cc using SimpleURLLoader

It's currently using URLFetcher. It should use SimpleURLLoader
instead to make it eventually work with the network service.

Bug:  872877 
Change-Id: Ib00befebaba5cee6dfc8a5319bb4153808810d22
Reviewed-on: https://chromium-review.googlesource.com/1203834
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588522}
[modify] https://crrev.com/8c02a65340b9fc1a787763c0c9744b47c265fd8c/chrome/browser/android/feedback/connectivity_checker.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c02a65340b9fc1a787763c0c9744b47c265fd8c

commit 8c02a65340b9fc1a787763c0c9744b47c265fd8c
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Sep 04 15:37:18 2018

[android] Migrate connectivity_checker.cc using SimpleURLLoader

It's currently using URLFetcher. It should use SimpleURLLoader
instead to make it eventually work with the network service.

Bug:  872877 
Change-Id: Ib00befebaba5cee6dfc8a5319bb4153808810d22
Reviewed-on: https://chromium-review.googlesource.com/1203834
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588522}
[modify] https://crrev.com/8c02a65340b9fc1a787763c0c9744b47c265fd8c/chrome/browser/android/feedback/connectivity_checker.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c02a65340b9fc1a787763c0c9744b47c265fd8c

commit 8c02a65340b9fc1a787763c0c9744b47c265fd8c
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Sep 04 15:37:18 2018

[android] Migrate connectivity_checker.cc using SimpleURLLoader

It's currently using URLFetcher. It should use SimpleURLLoader
instead to make it eventually work with the network service.

Bug:  872877 
Change-Id: Ib00befebaba5cee6dfc8a5319bb4153808810d22
Reviewed-on: https://chromium-review.googlesource.com/1203834
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588522}
[modify] https://crrev.com/8c02a65340b9fc1a787763c0c9744b47c265fd8c/chrome/browser/android/feedback/connectivity_checker.cc

Comment 8 by svil...@igalia.com, Sep 5

Status: Fixed (was: Assigned)
Closing
►

Sign in to add a comment