Migrate chrome/browser/android/contextualsearch/contextual_search_delegate.cc using SimpleURLLoader |
||||||||||
Issue description
,
Aug 9
,
Aug 22
,
Aug 28
,
Aug 28
,
Aug 28
,
Aug 29
dxie@ can you provide some context? Does this need to be done for servicification, even if only used in Clank code?
,
Sep 11
donnd, if you have not started on this, I would like to offer to take it.
,
Sep 11
Re comment #7, please help migrate this for clank.
,
Sep 11
tonikitoo@, I did start on this but didn't get very far, so if you'd like to take it that would be great. Let me know if you'd like help from me, and feel free to assign to yourself.
,
Sep 11
thanks donnd@. Will make sure to loop you in as reviewer.
,
Sep 13
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aef4857d31dd4d616d3efd94491e7b1a8deaf819 commit aef4857d31dd4d616d3efd94491e7b1a8deaf819 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Sep 25 18:49:18 2018 [android] Migrate ContextualSearchDelegate using SimpleURLLoader URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. This CL migrates Android's ContextualSearchDelegate and the respective unittests away from URLFetcher. Bug: 773295, 872875 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ifd2f3afd0db3ceaf75f6a8f972259c656ec7db69 Reviewed-on: https://chromium-review.googlesource.com/1221729 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#594025} [modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_delegate.cc [modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_delegate.h [modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc [modify] https://crrev.com/aef4857d31dd4d616d3efd94491e7b1a8deaf819/chrome/browser/android/contextualsearch/contextual_search_manager.cc
,
Sep 25
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dxie@chromium.org
, Aug 9