New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 872847 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 851021



Sign in to add a comment

Add favicons to the password drop-down

Project Member Reported by vasi...@chromium.org, Aug 9

Issue description

Cc: nepper@chromium.org maxwalker@chromium.org
Screenshot from 2018-08-09 21-04-14.png
7.1 KB View Download
Screenshot from 2018-08-09 21-03-23.png
13.4 KB View Download
Screenshot from 2018-08-09 20-47-52.png
10.9 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f22e030085d34db2ce4d3d9a18657ed30a652278

commit f22e030085d34db2ce4d3d9a18657ed30a652278
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Aug 13 10:43:24 2018

Implement favicons for the password dropdown on desktop.

TBR=pkotwicz@chromium.org

Bug:  872847 
Change-Id: Iae5cb8c652618511101b6516c918ee723712fe64
Reviewed-on: https://chromium-review.googlesource.com/1169803
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582546}
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/autofill/core/browser/suggestion.cc
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/autofill/core/browser/suggestion.h
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/f22e030085d34db2ce4d3d9a18657ed30a652278/components/password_manager/core/browser/password_manager_client.h

Labels: Merge-Request-69
I want to merge r582546 back. This is a pure UI fix for the password drop-down that is gonna be launched in M69 (see Issue 824470). It has been verified by the UX team on Canary.
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 14

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Aprpoved-69
Approving merge to M69 branch 3497 based on comment #3. Please merge ASAP so we can pick it up for this week Beta release. Thank you.
Labels: -Merge-Aprpoved-69 Merge-Approved-69
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 14

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4d11d61ccce184eaf6faf792d1ca2c0f161448

commit 9b4d11d61ccce184eaf6faf792d1ca2c0f161448
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Aug 14 18:27:38 2018

Implement favicons for the password dropdown on desktop.

TBR=pkotwicz@chromium.org, vasilii@chromium.org

(cherry picked from commit f22e030085d34db2ce4d3d9a18657ed30a652278)

Bug:  872847 
Change-Id: Iae5cb8c652618511101b6516c918ee723712fe64
Reviewed-on: https://chromium-review.googlesource.com/1169803
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582546}
Reviewed-on: https://chromium-review.googlesource.com/1174838
Cr-Commit-Position: refs/branch-heads/3497@{#620}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/chrome/browser/password_manager/chrome_password_manager_client.h
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/chrome/browser/ui/autofill/autofill_popup_layout_model.cc
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/autofill/core/browser/suggestion.cc
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/autofill/core/browser/suggestion.h
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/password_manager/core/browser/DEPS
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/password_manager/core/browser/password_autofill_manager.cc
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/password_manager/core/browser/password_autofill_manager.h
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/password_manager/core/browser/password_autofill_manager_unittest.cc
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/password_manager/core/browser/password_manager_client.cc
[modify] https://crrev.com/9b4d11d61ccce184eaf6faf792d1ca2c0f161448/components/password_manager/core/browser/password_manager_client.h

Status: Fixed (was: Started)

Sign in to add a comment