New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 872842 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

"chameleon:" label left behind on hosts with chameleon board

Project Member Reported by harpreet@chromium.org, Aug 9

Issue description

chameleon:bt_hid was missing on most hosts used for bt testing on chromeos15-row1-rack5 (7 hosts on this rack). Instead I noticed "chameleon:" label on most of these boards yesterday. https://paste.googleplex.com/4777199399862272

I went ahead and manually deleted chameleon: label and added chameleon:bt_hid. I understand that this is a dynamic label that should get added/deleted automatically based on whether the setup is working as expected or not. Today I checked the hosts again and the label is back to "chameleon:".

This bug is to make sure the complete label "chameleon:bt_hid" is removed and the partial label "chameleon:" is not left behind on the host.


josephsih@ - assigning this to you as you mentioned over chat that you'll take look but feel free to reassign as needed.
 
Hi Harpreet, thank you for filing the issue! I will take a look about what is going wrong here.
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bf6b07549fe28d294b10085aa743f91ed998eafc

commit bf6b07549fe28d294b10085aa743f91ed998eafc
Author: Joseph Hwang <josephsih@chromium.org>
Date: Fri Aug 10 12:08:32 2018

cros_label: fix a typo in ChameleonPeripheralsLabel

This patch fixed a typo so that the 'chameleon:bt_hid' label
could be generated correctly.

BUG=chromium:872842
TEST=Run a bluetooth test, e.g.,
(cros) $ test_that --args "chameleon_host=$CHAMELEON_IP" $DUT_IP
         bluetooth_AdapterPairing.mouse
And verify that 'chameleon:bt_hid' is found in the debug log as
DEBUG| labels: [..., 'chameleon', 'chameleon:bt_hid', ...]

Change-Id: I2dc10b64bd603c5f44edc363ff0c270870e4bba3
Reviewed-on: https://chromium-review.googlesource.com/1170146
Commit-Ready: Shyh-In Hwang <josephsih@chromium.org>
Tested-by: Shyh-In Hwang <josephsih@chromium.org>
Reviewed-by: Wai-Hong Tam <waihong@google.com>

[modify] https://crrev.com/bf6b07549fe28d294b10085aa743f91ed998eafc/server/cros/bluetooth/bluetooth_adapter_tests.py
[modify] https://crrev.com/bf6b07549fe28d294b10085aa743f91ed998eafc/server/hosts/cros_label.py

Sign in to add a comment