New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872838 link

Starred by 1 user
Status: Verified
Owner:
lijeffrey@chromium.org
Closed: Sep 10
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Auto revert not working

Project Member Reported by lijeffrey@chromium.org, Aug 9 
https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKFAWNocm9taXVtLmxpbnV4L0Nhc3QgTGludXgvNTcwMTcvYmxpbmtfaGVhcF91bml0dGVzdHMvU1c1amNtVnRaVzUwWVd4TllYSnJhVzVuVkdWemRDNVhaV0ZyUTJGc2JHSmhZMnRFYjJWelRtOTBVbVYyYVhabFJHVnNaWFJsWkZaaGJIVmwMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Result should have been auto reverted.

Root cause: The check for analysis.status == RUNNING is incorrect - the status is now only set at the end upon completion of an analysis, however this criteria is unnecessary. Auto revert can kick in as long as there's a culprit and it's a newly-added test.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/85dcd4f85367dee00d50996b7bee0db5b5bcfa36

commit 85dcd4f85367dee00d50996b7bee0db5b5bcfa36
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Thu Aug 09 20:45:39 2018

[Findit] Flake Analyzer - Analysis status not necessary for auto revert

Analysis.status is now only set at the very end of AnalyzeFlakePipeline
upon completion of OnFinalized at the root level, which is after the
logic for auto revert has ran. It is unnecessary for auto revert to check
the analysis's running status, as it is possible to revert once there's
a culprit with sufficient confidence.

Bug:  872838 
Change-Id: I8ce0c789f07a69c89b22e2b4c5840c6c5b915bee
Reviewed-on: https://chromium-review.googlesource.com/1169863
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/85dcd4f85367dee00d50996b7bee0db5b5bcfa36/appengine/findit/services/flake_failure/culprit_util.py
[modify] https://crrev.com/85dcd4f85367dee00d50996b7bee0db5b5bcfa36/appengine/findit/services/flake_failure/test/culprit_util_test.py

Comment 2 by lijeffrey@chromium.org, Sep 10

Status: Verified (was: Assigned)
►

Sign in to add a comment