New issue
Advanced search Search tips

Issue 872831 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Allow casting by clicking on a sink

Project Member Reported by taku...@chromium.org, Aug 9

Issue description

Instead of selecting a sink then clicking on the "Cast" button to cast, the dialog will allow casting simply by clicking on a sink. The Cast/Stop button will be removed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc

commit ef7cd50f66c23b981adf5b38d8d8a16626fd9afc
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Aug 24 20:30:23 2018

[Harmony Cast Dialog] Start and stop casting by clicking on a sink

Before this CL, starting and stopping casting was done with the button
at the bottom of the dialog. This CL removes the button, and allows the
user to start/stop by clicking on a sink.

A sink with a session is indicated by a stop icon replacing the device
type icon for the sink. After this CL the user can click anywhere on an
active sink to stop its session, but in the future we will likely make
only the stop icon clickable. When there is an issue, an info icon
replaces it instead.

The stop icon used is a placeholder, since we don't have the vector icon
used in the mocks yet.

Bug:  872831 

Change-Id: I638204db4cf751060be86e701c834e0abab2050e
Reviewed-on: https://chromium-review.googlesource.com/1168508
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585968}
[modify] https://crrev.com/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc/chrome/browser/ui/views/hover_button.h
[modify] https://crrev.com/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
[modify] https://crrev.com/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h
[modify] https://crrev.com/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc/chrome/browser/ui/views/media_router/cast_dialog_sink_button_unittest.cc
[modify] https://crrev.com/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc/chrome/browser/ui/views/media_router/cast_dialog_view.h
[modify] https://crrev.com/ef7cd50f66c23b981adf5b38d8d8a16626fd9afc/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment