New issue
Advanced search Search tips

Issue 872828 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Monitor blink_perf.image_decoder / ImageFrameGenerator::decode/* and always cc cblume@ (owner) in the regression bug

Project Member Reported by nednguyen@chromium.org, Aug 9

Issue description

Talking to cblume@ today, we found out that the tracing based metric "ImageFrameGenerator::decode" is a lot more stable, but doesn't seem to have any regressions attached to it. We want to make sure that we monitor this metric instead of the total duration blink_perf metric.

Chris also mentioned that he wanted to be cc'ed for all the perf regressions bugs from blink_perf.image_decoder benchmark
 
From the sheriff config: ChromiumPerf/*/blink_perf.*/*

So this is already coved. Confirmed using dev_console:

from dashboard.common import utils


t = utils.TestKey('ChromiumPerf/android-nexus5x-perf/blink_perf.image_decoder/ImageFrameGenerator::decode').get()

print t



As for being cc'd, I think when one fires off he should be since he's listed as an owner: https://cs.chromium.org/chromium/src/tools/perf/benchmarks/blink_perf.py?type=cs&q=blink_perf&sq=package:chromium&g=0&l=423
Owner: benjhayden@chromium.org
Ben, can you take this over? I looked and there was a recent bug filed for this time series: 891258 but the owner wasn't auto-cc'd as well. Code to do this is here: https://github.com/catapult-project/catapult/blob/master/dashboard/dashboard/file_bug.py#L96

This grabs the diagnostic info, looks like it ignores the owner and only uses the components.
As an aside, I'm currently getting emails saying "Please add the Monorail component for benchmark blink_perf.image_decoder".

I'm going to send out a CL to add that. Would that magically fix this problem?
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7da650367df7fe0417cce85ed07fccf997f642c

commit f7da650367df7fe0417cce85ed07fccf997f642c
Author: Chris Blume <cblume@chromium.org>
Date: Sun Oct 14 20:10:39 2018

Add Monorail component to blink_perf.image_decoder

The blink_perf.image_decoder perf test is missing its Monorail
component. This CL adds it.

BUG=872828

Change-Id: Ie095d0bced3bb18474024010cb76b588fe43be3c
Reviewed-on: https://chromium-review.googlesource.com/c/1278630
Commit-Queue: Chris Blume <cblume@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#599542}
[modify] https://crrev.com/f7da650367df7fe0417cce85ed07fccf997f642c/tools/perf/benchmark.csv
[modify] https://crrev.com/f7da650367df7fe0417cce85ed07fccf997f642c/tools/perf/benchmarks/blink_perf.py

Cc: -eakuefner@chromium.org
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment