Find dialog text too low contrast |
||||||||||||
Issue description70.0.3514.0 (Official Build) dev (64-bit) (cohort: Dev) Windows 10 If you press ctrl + f on any page, you'll get the find in page dialog. If there are more than one matches, you'll see a number #/#. That text has too low contrast, please see screenshot. Foreground:#B0B0B0 Background:#FFFFFF The contrast ratio is: 2.2:1
,
Aug 14
Also applies to Chrome OS Google Chrome 70.0.3511.0 (Official Build) canary (64-bit) Firmware Version Google_Eve.9584.160.0
,
Aug 21
,
Aug 21
,
Sep 18
,
Sep 18
,
Sep 18
,
Sep 18
,
Sep 25
,
Oct 1
,
Oct 4
LGTM
,
Oct 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02dec75001f49d7ccfadce1f30602414a3d248d6 commit 02dec75001f49d7ccfadce1f30602414a3d248d6 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Oct 09 22:19:56 2018 Update find bar, disabled icon, and download shelf colors for Refresh. This patch makes the following changes: * Disabled vector icon buttons now use kDisabledControlAlpha to derive their color (was a hardcoded value). * Find bar text are icons are now Grey 900 (was black). The secondary match label is now Grey 700 (was much lighter) which brings it above a11y minimums. * Download shelf text and bookmark bar text is now Grey 800 (was Grey 700). This results in the download status text and icons being non- spec colors, though they are now darker and thus should also meet a11y minimums. Screenshots are available in the associated bugs. This patch also refactors the download shelf logic intended to update colors when the View is added to a Widget into AddedToWidget instead of ViewHierarchyChanged, so that it will only run once. Bug: 872817 , 870539 Change-Id: I4a402a78c48be3cbb9310411f49e80f01d45451a Reviewed-on: https://chromium-review.googlesource.com/c/1255891 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#598108} [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/chrome/browser/themes/theme_properties.cc [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/chrome/browser/ui/views/download/download_item_view.cc [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/chrome/browser/ui/views/download/download_item_view.h [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/chrome/browser/ui/views/download/download_shelf_view.cc [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/chrome/browser/ui/views/download/download_shelf_view.h [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/chrome/browser/ui/views/find_bar_view.cc [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/ui/native_theme/common_theme.cc [modify] https://crrev.com/02dec75001f49d7ccfadce1f30602414a3d248d6/ui/views/controls/button/image_button_factory.cc
,
Oct 9
,
Oct 11
Able to reproduce the issue on chrome reported version# 70.0.3514.0(Build without fix) Verified the fix on Windows-10 on Chrome version #71.0.3577.0 as per the comment#0 Attaching screenshot for reference. Observed "Able to see Find dialog Text in high contrast" Hence, the fix is working as expected. Adding the verified label. Thanks! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by leberly@chromium.org
, Aug 10