New issue
Advanced search Search tips

Issue 872805 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

AppLaunch shows gaia and webui shelf when launching app if gaia has not finished preloading

Project Member Reported by jdufault@chromium.org, Aug 9

Issue description

Launch chrome, quickly launch an app before gaia has finished preloading; then gaia/login window will show instead of the app preload screen
 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 13

This issue is marked as a release blocker with no milestone associated. Please add an appropriate milestone.

All release blocking issues should have milestones associated to it, so that the issue can tracked and the fixes can be pushed promptly.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-70
Friendly ping to get an update as it is marked as RBS. Thanks
Cc: alemate@chromium.org
Update pending feedback from alemate@ regarding https://chromium-review.googlesource.com/c/chromium/src/+/1171251. He had some concerns and is working on reproducing it and testing out his own version of the fix.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/697ce2af53aa882ed9cfea5e13eb19f2e2031ef7

commit 697ce2af53aa882ed9cfea5e13eb19f2e2031ef7
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Sep 11 18:55:04 2018

cros: Prevent initial GAIA signin screen and kiosk splash from racing.

Bug:  872805 
Change-Id: I16c0de6d930b26ad6400cc0580f73fc2404c92b3
Reviewed-on: https://chromium-review.googlesource.com/1171251
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590424}
[modify] https://crrev.com/697ce2af53aa882ed9cfea5e13eb19f2e2031ef7/ui/login/display_manager.js

Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-70
Project Member

Comment 9 by sheriffbot@chromium.org, Sep 12

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 12

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8d7b92e8af0f39f353e8a41f3f73cc0eddd285

commit fa8d7b92e8af0f39f353e8a41f3f73cc0eddd285
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Wed Sep 12 22:47:15 2018

cros: Prevent initial GAIA signin screen and kiosk splash from racing.

Bug:  872805 
Change-Id: I16c0de6d930b26ad6400cc0580f73fc2404c92b3
Reviewed-on: https://chromium-review.googlesource.com/1171251
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#590424}(cherry picked from commit 697ce2af53aa882ed9cfea5e13eb19f2e2031ef7)
Reviewed-on: https://chromium-review.googlesource.com/1222311
Cr-Commit-Position: refs/branch-heads/3538@{#347}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/fa8d7b92e8af0f39f353e8a41f3f73cc0eddd285/ui/login/display_manager.js

Issue 881987 has been merged into this issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 1

Labels: -Merge-TBD

Sign in to add a comment