Seeing this on my Pixelbook as well. For me, seems to have started when I moved from Dev channel back to stable.

It happens to me as well.  Switching between logged-in profiles (where both profiles have tap-to-click off) is a reliable way to repro for me.  Currently in my corp profile it's now impossible to turn off tap-to-click, while in my non-corp profile, toggling will turn off tap to click (until I switch away and back to the profile).  Feedback sent.

This sounds like a pretty bad regression.  See b/113350421 for some feedback reports.

Ping. Why is this still unconfirmed?

Tagging this as a M69 stable blocker.  This made my eve and careena nearly unusable, and having the incorrect setting indicator was a horrible user experience.

+rkc Need this prioritized and fixed for stable.

Michael, does this belong in your plate? If not, we need to find another owner for this right away.

#5: Thanks, the multi-profile trick allows me to repro.

I can confirm that the pref is being set correctly and is not being changed.

I'll try a bisect. Apparently this pref was moved into //ash in M69 so I suspect that's the culprit: https://chromium-review.googlesource.com/1116210

+jamescook as warx@ is no longer on working on chrome.

I agree that CL seems suspicious. I commented on one thing I didn't notice in the initial review.

I wonder if there is a race between the prefs-handling code in //ash trying to apply the touchpad setting vs. the code in c/b/chromeos/preferences.cc.

Hope that helps.

I think I found a simpler repro case:

Tap-to-click is a synced pref, so if it's disabled on one device, it should be disabled on new devices too.

1. Add account to Chromebook
2. Try tapping after signing in

Expected: tapping doesn't click
Actual: tapping does click

(verify in chrome://settings/pointer-overlay that tap-to-click is already disabled)

Also, the device owner's settings should apply on the sign-in screen, but tap-to-click is enabled there too.

I've verified that this broke between 69.0.3474.0..69.0.3475.0, and that reverting https://chromium-review.googlesource.com/1116210 fixes this issue. (I'm not 100% confident due to OOBE issues making the repro case harder to set up.)

I wonder if switching between users only repros if there is no owner (the device is managed). I can't test this easily right now because admin.google.com keeps crashing.

I've also verified on the M69 branch now.

Reverts up at:

https://chromium-review.googlesource.com/c/chromium/src/+/1199624
https://chromium-review.googlesource.com/c/chromium/src/+/1199873

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c997aa787214c031b99f2a83a37898937aeae0fe

commit c997aa787214c031b99f2a83a37898937aeae0fe
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Fri Aug 31 23:38:59 2018

Revert "cros: move TapToClick prefs to ash"

This reverts commit 9f818c4100f203bea480a190cae7b08d06f4f4fb.

Reason for revert:  https://crbug.com/872786 

Original change's description:
> cros: move TapToClick prefs to ash
>
> changes:
> * Move kTapToClickEnabled and kOwnerTapToClickEnabled handling to ash
> * In this CL, above pref registrations are still in chrome side because
>   ash side doesn't have device owner info yet.
>
> TBR=stevenjb@chromium.org
>
> Bug: 817643
> Test: manual and test coverage
> Change-Id: I6b11eb65a40968eada67ebf2e8b4fb3f1f0eaddc
> Reviewed-on: https://chromium-review.googlesource.com/1116210
> Commit-Queue: Qiang Xu <warx@google.com>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570842}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  872786 
Test: On another device, sign in with an account and disable touchpad
      tap-to-click.
      Then on the target device, complete OOBE with the same account.
      In the first user session, tapping should not cause clicks. After
      signing out, tapping should also not cause clicks.

Change-Id: I67a67ba51b56bd14e656e332f8f64e219e3f80ef
Reviewed-on: https://chromium-review.googlesource.com/1199873
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588212}
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/ash/shell.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/ash/touch/touch_devices_controller.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/ash/touch/touch_devices_controller.h
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/ash/touch/touch_devices_controller_unittest.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/chrome/browser/chromeos/preferences_chromeos_browsertest.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/chrome/common/pref_names.cc
[modify] https://crrev.com/c997aa787214c031b99f2a83a37898937aeae0fe/chrome/common/pref_names.h

Requesting merges for this stable blocker.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This bug requires manual review: We are only 0 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Merge approved, M69.

Merge approved for Chrome OS M70

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision 93bfd37480c01f638b0732d5444f5484f2b02c8b was merged to refs/branch-heads/3538 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!

kbleicher: Maybe because you used your @google.com account, the auditor thinks this wasn't approved?

Can you please clarify if I did anything wrong here?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93bfd37480c01f638b0732d5444f5484f2b02c8b

commit 93bfd37480c01f638b0732d5444f5484f2b02c8b
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Tue Sep 04 19:14:10 2018

Revert "cros: move TapToClick prefs to ash"

This reverts commit 9f818c4100f203bea480a190cae7b08d06f4f4fb.

Reason for revert:  https://crbug.com/872786 

Original change's description:
> cros: move TapToClick prefs to ash
>
> changes:
> * Move kTapToClickEnabled and kOwnerTapToClickEnabled handling to ash
> * In this CL, above pref registrations are still in chrome side because
>   ash side doesn't have device owner info yet.
>
> TBR=stevenjb@chromium.org
>
> Bug: 817643
> Test: manual and test coverage
> Change-Id: I6b11eb65a40968eada67ebf2e8b4fb3f1f0eaddc
> Reviewed-on: https://chromium-review.googlesource.com/1116210
> Commit-Queue: Qiang Xu <warx@google.com>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570842}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  872786 
Test: On another device, sign in with an account and disable touchpad
      tap-to-click.
      Then on the target device, complete OOBE with the same account.
      In the first user session, tapping should not cause clicks. After
      signing out, tapping should also not cause clicks.

Change-Id: I67a67ba51b56bd14e656e332f8f64e219e3f80ef
Reviewed-on: https://chromium-review.googlesource.com/1199873
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588212}(cherry picked from commit c997aa787214c031b99f2a83a37898937aeae0fe)
Reviewed-on: https://chromium-review.googlesource.com/1204833
Cr-Commit-Position: refs/branch-heads/3538@{#33}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/ash/shell.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/ash/touch/touch_devices_controller.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/ash/touch/touch_devices_controller.h
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/ash/touch/touch_devices_controller_unittest.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/chrome/browser/chromeos/preferences_chromeos_browsertest.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/chrome/common/pref_names.cc
[modify] https://crrev.com/93bfd37480c01f638b0732d5444f5484f2b02c8b/chrome/common/pref_names.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6da367938a43f868f91669a8ce8106ce17c78f3

commit e6da367938a43f868f91669a8ce8106ce17c78f3
Author: Michael Giuffrida <michaelpg@chromium.org>
Date: Wed Sep 05 19:48:59 2018

Revert "cros: move TapToClick prefs to ash"

This reverts commit 9f818c4100f203bea480a190cae7b08d06f4f4fb.

Reason for revert:  https://crbug.com/872786 

Original change's description:
> cros: move TapToClick prefs to ash
>
> changes:
> * Move kTapToClickEnabled and kOwnerTapToClickEnabled handling to ash
> * In this CL, above pref registrations are still in chrome side because
>   ash side doesn't have device owner info yet.
>
> TBR=stevenjb@chromium.org
>
> Bug: 817643
> Test: manual and test coverage
> Change-Id: I6b11eb65a40968eada67ebf2e8b4fb3f1f0eaddc
> Reviewed-on: https://chromium-review.googlesource.com/1116210
> Commit-Queue: Qiang Xu <warx@google.com>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570842}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  872786 
Test: On another device, sign in with an account and disable touchpad
      tap-to-click.
      Then on the target device, complete OOBE with the same account.
      In the first user session, tapping should not cause clicks. After
      signing out, tapping should also not cause clicks.

Change-Id: I67a67ba51b56bd14e656e332f8f64e219e3f80ef
Reviewed-on: https://chromium-review.googlesource.com/1199624
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#883}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/ash/public/cpp/ash_pref_names.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/ash/public/cpp/ash_pref_names.h
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/ash/shell.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/ash/touch/touch_devices_controller.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/ash/touch/touch_devices_controller.h
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/ash/touch/touch_devices_controller_unittest.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/chrome/browser/chromeos/preferences_chromeos_browsertest.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/chrome/browser/prefs/pref_service_incognito_whitelist.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/chrome/common/pref_names.cc
[modify] https://crrev.com/e6da367938a43f868f91669a8ce8106ce17c78f3/chrome/common/pref_names.h