New issue
Advanced search Search tips

Issue 872777 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature
Launch-Exp-Leadership: NA
Rollout-Type: Default



Sign in to add a comment

Support hrefTranslate attribute

Project Member Reported by dtapu...@chromium.org, Aug 9

Issue description

Please provide a link to your UX implementation review here before requesting review.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6627e18c1988153dddbc01d77f5d7484a6fe2a7

commit c6627e18c1988153dddbc01d77f5d7484a6fe2a7
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Aug 30 15:07:19 2018

Add experimental support for the hrefTranslate attribute.

This adds the plumbing that exposes the attribute dynamically. So that
it is only bound when a translate service is available. The translate
team will hook into the frame load request to grab the attribute
from the anchor.

Doc: https://github.com/dtapuska/html-translate
Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/hmASm1yhi5s/7vqmt7CwDgAJ

BUG=872777

Change-Id: I0004fe33afeaf3255031bc87f47c7f4d1209ffc8
Reviewed-on: https://chromium-review.googlesource.com/1175031
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587580}
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/chrome/browser/translate/translate_service.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/chrome/browser/translate/translate_service.h
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/components/translate/core/browser/translate_manager.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/components/translate/core/browser/translate_manager.h
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/content/public/common/web_preferences.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/content/public/common/web_preferences.h
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/content/renderer/render_view_impl.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/content/shell/renderer/layout_test/blink_test_helpers.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/blink/renderer/core/html/html_anchor_element.idl
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/blink/renderer/core/html/html_attribute_names.json5
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/blink/renderer/core/loader/frame_load_request.h
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/c6627e18c1988153dddbc01d77f5d7484a6fe2a7/third_party/blink/renderer/platform/runtime_enabled_features.json5

Labels: -Type-Launch-OWP Type-Launch
Type-Launch-OWP is deprecated.
Labels: MovedFromTypeLaunchOWP
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/358a11611344fb76bac117b3bc444c29c204f6a9

commit 358a11611344fb76bac117b3bc444c29c204f6a9
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Fri Nov 02 16:26:42 2018

Add hrefTranslate to NavigationHandle so the browser can handle it

This CL takes the experimental hrefTranslate attribute on <a> tags
and carries it to the creation of NavigationHandle. This allows
Translate browser code to be aware of its value in
ContentTranslateDriver::DidFinishNavigation.

BUG:900586,872777

Change-Id: Ie7c633aca8a91f1137862898c992c5f63cc1fcca
Reviewed-on: https://chromium-review.googlesource.com/c/1308434
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604952}
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/components/translate/content/browser/content_translate_driver.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/browser/frame_host/navigation_entry_impl.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/browser/navigation_browsertest.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/common/frame_messages.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/common/navigation_params.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/common/navigation_params.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/public/browser/navigation_handle.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/public/test/render_view_test.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/content/renderer/render_frame_impl.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/public/web/web_local_frame_client.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/renderer/core/exported/local_frame_client_impl.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/renderer/core/exported/local_frame_client_impl.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/renderer/core/frame/local_frame_client.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/renderer/core/loader/empty_clients.cc
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/renderer/core/loader/empty_clients.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/renderer/core/loader/frame_load_request.h
[modify] https://crrev.com/358a11611344fb76bac117b3bc444c29c204f6a9/third_party/blink/renderer/core/loader/frame_loader.cc

Labels: OS-Windows Rollout-Type-Default
Labels: Launch-Exp-Leadership-NA
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Description: Show this description
Labels: -Type-Launch Type-FLT-Launch FLT-Conversion
Automatic generating of FLT Launch data.
Labels: Restrict-View-Google
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a38e325b9b09609b763252093e195b6a012e0dc4

commit a38e325b9b09609b763252093e195b6a012e0dc4
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Nov 13 03:01:17 2018

Setup an origin trial for HrefTranslate.

In order to setup origin trial need to make the feature & origin trial
dependent on a new runtime enabled feature that is dynamically set if
the translation service is available.

BUG=872777

Change-Id: Ic6fc5947a50c4e2a5ac659c83d75a972c31b0c12
Reviewed-on: https://chromium-review.googlesource.com/c/1332780
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607462}
[modify] https://crrev.com/a38e325b9b09609b763252093e195b6a012e0dc4/content/renderer/render_view_impl.cc
[modify] https://crrev.com/a38e325b9b09609b763252093e195b6a012e0dc4/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/a38e325b9b09609b763252093e195b6a012e0dc4/third_party/blink/renderer/build/scripts/templates/origin_trials.cc.tmpl
[modify] https://crrev.com/a38e325b9b09609b763252093e195b6a012e0dc4/third_party/blink/renderer/core/html/html_anchor_element.idl
[modify] https://crrev.com/a38e325b9b09609b763252093e195b6a012e0dc4/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/a38e325b9b09609b763252093e195b6a012e0dc4/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a391fb3711e8cd60b7eb3612df70482cf4102c6

commit 2a391fb3711e8cd60b7eb3612df70482cf4102c6
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Nov 14 18:13:07 2018

Add ability to track usage of the hrefTranslate attribute via use counter.

Read the attribute based on the origin trial being enabled otherwise
even if it wasn't the attribute would get set on the navigation param.
In the same branch count the usage as this will be useful for the origin
trial.

BUG=872777

Change-Id: I1cc4eeba4051cf45c65e54f7dad02ec1114ecb1a
Reviewed-on: https://chromium-review.googlesource.com/c/1334198
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608039}
[modify] https://crrev.com/2a391fb3711e8cd60b7eb3612df70482cf4102c6/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/2a391fb3711e8cd60b7eb3612df70482cf4102c6/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/2a391fb3711e8cd60b7eb3612df70482cf4102c6/tools/metrics/histograms/enums.xml

Labels: FLT-Conversion-1
Please do not modify this value.
Updating this issue's FLT-Conversion label.
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93a1167ada9d699c1b555c2d8fee2a0bb226e626

commit 93a1167ada9d699c1b555c2d8fee2a0bb226e626
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Wed Nov 21 16:44:42 2018

Wire up hrefTranslate in OpenURL

This is simply a follow-up on https://chromium-review.googlesource.com/c/1315949
that handles links being opened in a different tab.

Bug: 900586,872777
Change-Id: I212e1d787db30da988dddaff0fc9e29978d7222e
Reviewed-on: https://chromium-review.googlesource.com/c/1331667
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610103}
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/chrome/browser/ui/browser.cc
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/chrome/browser/ui/browser_navigator.cc
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/chrome/browser/ui/browser_navigator_params.h
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/browser/frame_host/navigator.h
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/browser/frame_host/navigator_impl.h
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/browser/security_exploit_browsertest.cc
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/common/frame_messages.h
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/public/browser/navigation_controller.h
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/public/browser/page_navigator.h
[modify] https://crrev.com/93a1167ada9d699c1b555c2d8fee2a0bb226e626/content/renderer/render_frame_impl.cc

Labels: Type-Feature
Labels: -Restrict-View-Google
Bulk updating old OWP-Launch bugs to once again be public. OWP-Launch (previously used as public/transparent blink launch process) was not supposed to have been remapped to Type=Launch.
Labels: Type-FLT-Launch
Preparing this issue to be converted back into the old format.

Will change Type back to 'Feature' after.
Labels: FLT-Conversion
Labels: Type-Feature
Labels: Type-FLT-Launch
Labels: Type-Feature

Sign in to add a comment