New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872759 link

Starred by 1 user
Status: Fixed
Owner:
eugene...@chromium.org
Closed: Nov 5
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ichikawa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Disallow ios/chrome includes to ios/web_view

Project Member Reported by eugene...@chromium.org, Aug 9 
ios/web_view should be built on top of ios/web and components

Comment 1 by eugene...@chromium.org, Nov 2

Labels: -M-70 M-72
Status: Started (was: Assigned)
crrev.com/c/1315350
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85aa920b45323e92e5d2dfb09ce61109c52147c9

commit 85aa920b45323e92e5d2dfb09ce61109c52147c9
Author: Eugene But <eugenebut@google.com>
Date: Mon Nov 05 17:12:05 2018

Disallow certain includes in ios/web_view.

ios/chrome is not allowed as chrome application layer.

ios/web is not allowed as private implementation.
ios/web/public is allowed as public API layer for ios/web

Bug:  872759 
Change-Id: I0900bfe2adf740836fdf4572d356913a3901af0e
Reviewed-on: https://chromium-review.googlesource.com/c/1315350
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605368}
[modify] https://crrev.com/85aa920b45323e92e5d2dfb09ce61109c52147c9/ios/web_view/DEPS

Comment 3 by eugene...@chromium.org, Nov 5

Status: Fixed (was: Started)
►

Sign in to add a comment