New issue
Advanced search Search tips

Issue 872735 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Integrate background fetch with quota

Project Member Reported by rayankans@chromium.org, Aug 9

Issue description

1) don't start a fetch if there isn't enough quota
2) abandon a fetch if we run out of quota during
 
Cc: rayankans@chromium.org
 Issue 845490  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8

commit 77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8
Author: Rayan Kanso <rayankans@chromium.org>
Date: Fri Aug 17 16:44:23 2018

[Background Fetch] Take remaining quota into account in Data Manager.

- Before registering the fetch make sure there is enough quota to
  complete the fetch.
- Abandon the fetch if there is no quota to persist the response.

TBR=avi@chromium.org

Bug:  872735 
Change-Id: I2a8348209989f85722e20bd8a5bccc75015fbf51
Reviewed-on: https://chromium-review.googlesource.com/1169202
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584099}
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_context.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_context.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_data_manager.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_data_manager.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_data_manager_observer.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_job_controller_unittest.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_service_unittest.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_test_data_manager.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/background_fetch_test_data_manager.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/storage/create_metadata_task.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/storage/create_metadata_task.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/storage/database_task.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/storage/database_task.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/storage/mark_request_complete_task.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/background_fetch/storage/mark_request_complete_task.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/content/public/browser/background_fetch_delegate.h
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/third_party/blink/public/platform/modules/background_fetch/background_fetch.mojom
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/third_party/blink/renderer/modules/background_fetch/background_fetch_registration.cc
[modify] https://crrev.com/77bf1926a9d8e349b3b5f4d5f88bd9033ae8e4e8/third_party/blink/renderer/modules/background_fetch/background_fetch_update_ui_event.cc

Status: Fixed (was: Started)

Sign in to add a comment