SignalSenderVerificationTest.TestSignalAccepted is flaky on linux tests dbg |
|
Issue descriptionThis test (part of dbus_unittests) flakily times out like below. Example run: <https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/73663> [ RUN ] SignalSenderVerificationTest.TestSignalAccepted ../../dbus/signal_sender_verification_unittest.cc:78: Failure Value of: test_service_->WaitUntilServiceIsStarted() Actual: false Expected: true Stack trace: #0 0x000000376a40 StackTraceGetter::CurrentStackTrace() #1 0x00000039eb87 testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #2 0x00000039dfed testing::internal::AssertHelper::operator=() #3 0x000000328a18 dbus::SignalSenderVerificationTest::SetUp() #4 0x0000003d9e1e testing::internal::HandleSehExceptionsInMethodIfSupported<>() [13251:13251:0809/052854.961445:976409203:ERROR:bus.cc(505)] Failed to shutdown the bus Received signal 11 SEGV_MAPERR 000000000088 #0 0x7f60a6bd973d base::debug::StackTrace::StackTrace() #1 0x7f60a68df5ec base::debug::StackTrace::StackTrace() #2 0x7f60a6bd9194 base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f60a5af2330 <unknown> #4 0x00000033a52c base::Thread::message_loop() #5 0x00000032e7e9 dbus::TestService::ShutdownAndBlock() #6 0x000000329f4d dbus::SignalSenderVerificationTest::TearDown() #7 0x0000003d9e1e testing::internal::HandleSehExceptionsInMethodIfSupported<>() #8 0x0000003cc4d2 testing::internal::HandleExceptionsInMethodIfSupported<>() #9 0x0000003af64b testing::Test::Run() #10 0x0000003b0030 testing::TestInfo::Run() #11 0x0000003b0adf testing::TestCase::Run() #12 0x0000003c2e98 testing::internal::UnitTestImpl::RunAllTests() #13 0x0000003d9eae testing::internal::HandleSehExceptionsInMethodIfSupported<>() #14 0x0000003cdcf2 testing::internal::HandleExceptionsInMethodIfSupported<>() #15 0x0000003c2af7 testing::UnitTest::Run() #16 0x00000041cd01 RUN_ALL_TESTS() #17 0x00000041962b base::TestSuite::Run() #18 0x0000002fdbed _ZN4base8internal13FunctorTraitsIMN4dbus17ObjectManagerTestEFvvEvE6InvokeIS5_PNS2_57ObjectManagerTest_PropertiesChangedAsObjectsReceived_TestEJEEEvT_OT0_DpOT1_ #19 0x0000002fdb64 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4dbus17ObjectManagerTestEFvvEJPNS4_57ObjectManagerTest_PropertiesChangedAsObjectsReceived_TestEEEEvOT_DpOT0_ #20 0x0000002fdb15 _ZN4base8internal7InvokerINS0_9BindStateIMN4dbus17ObjectManagerTestEFvvEJNS0_17UnretainedWrapperINS3_57ObjectManagerTest_PropertiesChangedAsObjectsReceived_TestEEEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS9_EEEJLm0EEEEvOT_OT0_NSG_16integer_sequenceImJXspT1_EEEE #21 0x0000004193c9 _ZN4base8internal7InvokerINS0_9BindStateIMNS_9TestSuiteEFivEJNS0_17UnretainedWrapperIS3_EEEEEFivEE7RunOnceEPNS0_13BindStateBaseE #22 0x00000043416e _ZNO4base12OnceCallbackIFivEE3RunEv #23 0x00000042cac5 base::(anonymous namespace)::LaunchUnitTestsInternal() #24 0x00000042c915 base::LaunchUnitTests() #25 0x0000004192a0 main #26 0x7f60a4ac9f45 __libc_start_main #27 0x00000027302a _start r8: 0000000000000000 r9: 00007ffd283146d0 r10: fffffffffffffe20 r11: 0000000000000000 r12: 0000000000273000 r13: 00007ffd28316050 r14: 0000000000000000 r15: 0000000000000000 di: 0000000000000000 si: 00007ffd28314778 bp: 00007ffd28314e10 bx: 0000000000000000 dx: 00007f60a680b6b4 ax: 000036960a86c7d0 cx: 5c015a17ac3b8d00 sp: 00007ffd28314e10 ip: 000000000033a52c efl: 0000000000010202 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000088 [end of stack trace] Calling _exit(1). Core file will not be generated.
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bbeb5c8e30902453ab121eaede2649007b41299 commit 3bbeb5c8e30902453ab121eaede2649007b41299 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Mon Aug 13 04:58:39 2018 dbus: Stop timing out in TestService::WaitUntilServiceIsStarted() Removing the timeout to have one less sources of flakiness. BUG=872732 TEST=dbus_unittests Change-Id: I7ca390a19a77686df268332850e3951e6d13d3d1 Reviewed-on: https://chromium-review.googlesource.com/1170719 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Satoru Takabayashi <satorux@chromium.org> Cr-Commit-Position: refs/heads/master@{#582506} [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/end_to_end_async_unittest.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/end_to_end_sync_unittest.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/object_manager_unittest.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/object_proxy_unittest.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/property_unittest.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/signal_sender_verification_unittest.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/test_server.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/test_service.cc [modify] https://crrev.com/3bbeb5c8e30902453ab121eaede2649007b41299/dbus/test_service.h
,
Aug 13
I landed http://crrev.com/582506 to make the tests less flaky. Also, with this CL, when the test times out, stack trace on the test log shows where the test actually gets stuck. |
|
►
Sign in to add a comment |
|
Comment 1 by hashimoto@chromium.org
, Aug 10