New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872724 link

Starred by 1 user
Status: Fixed
Owner:
█ valeriyas@google.com
Last visit > 30 days ago
Closed: Oct 27
Cc:
droger@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 771911



Sign in to add a comment

Use refresh tokens directly for OAuth Multilogin

Project Member Reported by droger@chromium.org, Aug 9 
This is an optimization.

On Android, iOS and ChromeOS, OAuth multilogin requires access tokens.
However, on desktop platforms, we may use refresh tokens directly, and thus skip the access token requests.

Note that refresh tokens are currently not exposed outside of the token service, so this will require changes in the token service to either expose them or have the token service somehow make the multilogin request.

Comment 1 by droger@chromium.org, Aug 21

Cc: -valeriyas@google.com droger@chromium.org
Owner: valeriyas@google.com
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 20

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by droger@chromium.org, Sep 20

Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/828ca35bdad88e751c3461c758b22f962d9f2673

commit 828ca35bdad88e751c3461c758b22f962d9f2673
Author: Valeriya Sinevich <valeriyas@google.com>
Date: Mon Oct 22 11:38:58 2018

[Signin] Invalidate tokens if Multilogin returns INVALID_TOKENS error.

Set refresh tokens in error on Desktop, remove cached access tokens on mobile.

Bug:  872724 

Change-Id: I4267bfb2e70219b9f8f9adfa604dc6f6a01333f7
Reviewed-on: https://chromium-review.googlesource.com/c/1273136
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601529}
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/components/signin/core/browser/gaia_cookie_manager_service.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/components/signin/core/browser/gaia_cookie_manager_service.h
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/components/signin/core/browser/gaia_cookie_manager_service_unittest.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/BUILD.gn
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/fake_oauth2_token_service.h
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/gaia_auth_consumer.h
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/gaia_auth_fetcher.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/gaia_auth_fetcher_unittest.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service.h
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service_delegate.h
[add] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service_delegate_unittest.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth2_token_service_unittest.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth_multilogin_result.cc
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth_multilogin_result.h
[modify] https://crrev.com/828ca35bdad88e751c3461c758b22f962d9f2673/google_apis/gaia/oauth_multilogin_result_unittest.cc

Comment 5 by valeriyas@google.com, Oct 27

Status: Fixed (was: Assigned)
►

Sign in to add a comment