New issue
Advanced search Search tips

Issue 872717 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move PolicyHandlers out of configuration_policy_handler_list_factory

Project Member Reported by ljusten@chromium.org, Aug 9

Issue description

Move
- ForceSafeSearchPolicyHandler
- ForceYouTubeSafetyModePolicyHandler
- BrowsingHistoryPolicyHandler
- SecureOriginPolicyHandler
out of configuration_policy_handler_list_factory to the places that use the prefs - before it gets too crazy.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ad6465f517124e8a23434c21f1c543ad47b1d5a

commit 3ad6465f517124e8a23434c21f1c543ad47b1d5a
Author: Lutz Justen <ljusten@chromium.org>
Date: Mon Aug 20 11:54:28 2018

Move PolicyHandlers out of handler list factory

Moves
- ForceSafeSearchPolicyHandler
- ForceYouTubeSafetyModePolicyHandler
- BrowsingHistoryPolicyHandler
- SecureOriginPolicyHandler
out of configuration_policy_handler_list_factory.cc to the places that
use the prefs. Merely a cleanup CL - no other changes.

BUG= chromium:872717 
TEST=tryjobs

Change-Id: Ic234b0aac5f869abe9dcb99908d4ffb615bc4f2c
Reviewed-on: https://chromium-review.googlesource.com/1169173
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584408}
[modify] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/BUILD.gn
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/policy/browsing_history_policy_handler.cc
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/policy/browsing_history_policy_handler.h
[modify] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/profiles/force_safe_search_policy_handler.cc
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/profiles/force_safe_search_policy_handler.h
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/profiles/force_youtube_safety_mode_policy_handler.cc
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/profiles/force_youtube_safety_mode_policy_handler.h
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/ssl/secure_origin_policy_handler.cc
[add] https://crrev.com/3ad6465f517124e8a23434c21f1c543ad47b1d5a/chrome/browser/ssl/secure_origin_policy_handler.h

Status: Fixed (was: Assigned)

Sign in to add a comment