Issue metadata
Sign in to add a comment
|
[WPT] New failures introduced in external/wpt/svg by import https://crrev.com/c/1168738 |
||||||||||||||||||||||
Issue descriptionWPT import https://crrev.com/c/1168738 introduced new failures in external/wpt/svg: List of new failures: external/wpt/svg/types/scripted/event-handler-all-document-element-events.svg new failing tests: https://crrev.com/c/1168738/4/third_party/WebKit/LayoutTests/external/wpt/svg/types/scripted/event-handler-all-document-element-events-expected.txt external/wpt/svg/text/reftests/text-inline-size-007.svg [ Failure ] external/wpt/svg/text/reftests/text-inline-size-005.svg [ Failure ] external/wpt/svg/text/reftests/text-multiline-002.svg [ Failure ] [ Linux Win ] external/wpt/svg/text/reftests/text-multiline-003.svg [ Failure ] external/wpt/svg/text/reftests/text-inline-size-201.svg [ Failure ] external/wpt/svg/text/reftests/text-inline-size-001.svg [ Failure ] external/wpt/svg/painting/reftests/markers-orient-001.svg [ Failure ] external/wpt/svg/text/reftests/text-inline-size-002.svg [ Failure ] external/wpt/svg/text/reftests/text-inline-size-006.svg [ Failure ] [ Linux Win ] external/wpt/svg/text/reftests/text-inline-size-003.svg [ Failure ] external/wpt/svg/text/reftests/text-multiline-001.svg [ Failure ] external/wpt/svg/text/reftests/text-inline-size-101.svg [ Failure ] This import contains upstream changes from 5a3a984492dcd1b1586576790922baf0a208dfb5 to f69ed366b8c028c882a4fb582b20d6982577c00f: Check [NewObject] on show(), use webdriver (#11775): https://github.com/web-platform-tests/wpt/commit/f69ed366b8c028c882a4fb582b20d6982577c00f HTML: test 'face' and 'size' attribute on <font> element: https://github.com/web-platform-tests/wpt/commit/b7fa1d84d8d38671049d805ca1b7c025c12b0fd8 Add RTCIceTransport IDL + binding skeleton: https://github.com/web-platform-tests/wpt/commit/c4bd959ae80333a356e43c651ea26ee4baf017e2 [IntersectionObserver] Fix initial notifications for non-zero threshold: https://github.com/web-platform-tests/wpt/commit/a6abe150c4901fdb461fc853f3b067ac495ce8f3 MSE: Make changeType-play layout tests' audio mime-type be audio-specific: https://github.com/web-platform-tests/wpt/commit/531bf4a9a5fd6e7812a40a8df1a6c32b4ba748e3 Hide URL.createObjectURL from ServiceWorker: https://github.com/web-platform-tests/wpt/commit/3941f3cdfb8d128f5e150734f125942fa60e689f Rename idlharness tests for [SecureContext] APIs to .https. (#12353): https://github.com/web-platform-tests/wpt/commit/1e79f6d25a79ca5e5d47bc3696904c303d173033 patch 2 - Send nsChangeHint_UpdateContainingBlock when containing block-ness changes due to one property change, while another property that might trigger containing block-ness doesn't do so because of the frame type.: https://github.com/web-platform-tests/wpt/commit/68b48c5da7a543b0fa5a7081f9e3c15bf96f18df patch 1 - Make inline frames be abs-pos containing blocks for reasons other than being relatively positioned.: https://github.com/web-platform-tests/wpt/commit/39109be81d24b1782fb05ca4ea9da502d402f8d9 DOM: test for the absence of XMLDocument.prototype.load: https://github.com/web-platform-tests/wpt/commit/580e5b52e20a9a2b4f63e9d33e9c4b039c68ce08 DOM: add a test for getRootNode({composed:true}): https://github.com/web-platform-tests/wpt/commit/315ad5300562f570b3fdffcfc8041dbd5024b592 [css-grid] Update grid-layout-properties.html to new behavior: https://github.com/web-platform-tests/wpt/commit/d26f049f434b58e97b121e560fd90d0b9c80d454 Add tests for dynamic changes to base urls (#12313): https://github.com/web-platform-tests/wpt/commit/7d91339d2e83b8f7f7649dfcd33a29a581421ebd Ensure that in-repo files that match gitignore rules are synced.: https://github.com/web-platform-tests/wpt/commit/157d21f4b647ca4ddcdb0a62d304dcaa43a9c265 Fix worklet referrer tests to match spec: https://github.com/web-platform-tests/wpt/commit/b315ee9209a6039e96412520163764b3ae360605 Update nokogiri version: https://github.com/web-platform-tests/wpt/commit/6d9f42cb8c5b91915b70e1957273617b84dda0ae Add WPT tests for inert: https://github.com/web-platform-tests/wpt/commit/1048171f1150d1e495960ac2ea5f9a40cee032e6 Fix module worker referrer tests: https://github.com/web-platform-tests/wpt/commit/140efeeb75c11af8feb410fa9dcef8aa62c60159 Have the second OptionallyBreak actually make sense.: https://github.com/web-platform-tests/wpt/commit/87962ab4acbf999d184cb00e55e941cf63ab362c Don't re-attach ::first-letter during style recalc.: https://github.com/web-platform-tests/wpt/commit/3dd27ccc5876d3ad06ccce491da49b477d623621 Don't try to re-encode already-encoded bytes when serializing.: https://github.com/web-platform-tests/wpt/commit/db02d2880ad332389e619262130354bf7f9e4e21 Sync Mozilla tests as of https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856 . (#12342): https://github.com/web-platform-tests/wpt/commit/526dde4f947afb3c93dd809b1622371465146a87 [IntersectionObserver] Fix target rect calculation for LayoutInline.: https://github.com/web-platform-tests/wpt/commit/8d1a4d053fbbe9a407b150807b5804ab3ab1d839 Part a: Add a wasm setting to the wpt .ini expectation files: https://github.com/web-platform-tests/wpt/commit/d309efd6d5a63376db72494c21d403624c14d7af Add some tests for the Wasm JS API; +bbouvier: https://github.com/web-platform-tests/wpt/commit/5c219ef55a4b2099c0f4c53b9669df10d73e6f3a Fix some typos in testharness.js.: https://github.com/web-platform-tests/wpt/commit/5ee7f865c347c346d8bf3295d7b5e2602f5caca7 Merge pull request #10926 from Tavmjong/markers-orient: https://github.com/web-platform-tests/wpt/commit/eea0b54014e970a2f94f1c35ec6e18ece76beb76 Merge pull request #10868 from Tavmjong/inline-size: https://github.com/web-platform-tests/wpt/commit/4d887869b49459f5fc5313171b94aea62de7d7bb Merge pull request #10275 from dstorey/svgaelement-additions: https://github.com/web-platform-tests/wpt/commit/60f5bae752dd625ae83a730c635254cdb9f3d970 Merge pull request #10249 from dstorey/svg-document-element-events: https://github.com/web-platform-tests/wpt/commit/1529e32ac8073c48e872e7d705a10daa24decbbf Merge pull request #10871 from Tavmjong/multi-line: https://github.com/web-platform-tests/wpt/commit/910640bcb4924b36e4cd5fc1dc0fd12ff13c09be Remove unneeded test meta data.: https://github.com/web-platform-tests/wpt/commit/9c456d381680262cdba72fbf6fdddc73258e7be3 [affecting this directory] Remove unneeded test meta data.: https://github.com/web-platform-tests/wpt/commit/4d54a9c8e573d710aaf0eb4b55a64efe22e0bae2 [affecting this directory] Remove unused test data per review.: https://github.com/web-platform-tests/wpt/commit/f3ec29736a50376439bfbe2ee413460b110ef558 [affecting this directory] Fix lint error.: https://github.com/web-platform-tests/wpt/commit/4dbb7a824857465007ec63b079be64a5c3ded6e4 [affecting this directory] Add test for marker 'orient' attribute.: https://github.com/web-platform-tests/wpt/commit/958c04309c56b46b3afa21d1a674c248485763d1 [affecting this directory] Fix titles.: https://github.com/web-platform-tests/wpt/commit/4b16c3d9d5ce50d8f3346ac6766ac8d26b8a5383 [affecting this directory] Add basic text multiline text (via 'white-space').: https://github.com/web-platform-tests/wpt/commit/36d925eee2a1e1e89d795f67281c92e43126d4ff [affecting this directory] Fix casing for a element: https://github.com/web-platform-tests/wpt/commit/d89cd24ee381abb6cd74fc315779281d86bffe1d [affecting this directory] Add SVGAElement relList test: https://github.com/web-platform-tests/wpt/commit/2a03903267f9b09cf4d8b616eb6c72c069ec3f2f [affecting this directory] Add download test: https://github.com/web-platform-tests/wpt/commit/6560a759371ed28b0e5d7cba48c2f13d9f95e321 [affecting this directory] Add tests for a.text: https://github.com/web-platform-tests/wpt/commit/aa1d3d13e679b8114983a440b601e2003515dcc6 [affecting this directory] Add tests for a.rel: https://github.com/web-platform-tests/wpt/commit/1297db1895c6c15897cf63da55b57ecaf78dcaee [affecting this directory] Add test for DocumentAndElementEventHandlers in SVG: https://github.com/web-platform-tests/wpt/commit/d241659cf7ee83d5b0b15b999676a2ca7b276808 [affecting this directory] Add basic text 'inline-size' tests.: https://github.com/web-platform-tests/wpt/commit/abfa69e689f63065e243ca8629ef1a4c33326362 [affecting this directory]
,
Aug 13
Breakdown: external/wpt/svg/text/reftests/text-multiline-001.svg external/wpt/svg/text/reftests/text-multiline-002.svg external/wpt/svg/text/reftests/text-multiline-003.svg external/wpt/svg/text/reftests/text-inline-size-001.svg external/wpt/svg/text/reftests/text-inline-size-002.svg external/wpt/svg/text/reftests/text-inline-size-003.svg external/wpt/svg/text/reftests/text-inline-size-005.svg external/wpt/svg/text/reftests/text-inline-size-006.svg external/wpt/svg/text/reftests/text-inline-size-007.svg external/wpt/svg/text/reftests/text-inline-size-101.svg external/wpt/svg/text/reftests/text-inline-size-201.svg These because of lack of support - relevant tasks/bugs: issue 366558 (multiline) and issue 366553 (inline-size.) Will update bugref. external/wpt/svg/types/scripted/event-handler-all-document-element-events.svg This looks like issue 835570 . Will update bugref. external/wpt/svg/painting/reftests/markers-orient-001.svg This looks like subpixel difference - in part at least because the test (non-ref) has a red "reference" under the main test subjects - leading to bleeding on the edges of the markers (at least when using rasterizers that are not of the MSAA type.) Maybe there are additional issues (could be due to computing the marker transform differently for instance), but it's hard to tell without first "fixing" the test. I'll make a minimal tweak to hide the red reference, and we can take it from there.
,
Aug 13
I'll note that the "[ Linux Win ]" annotations are a bit odd (indicating passes on Mac), so I'd suspect that something might be up with the tests there.
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92c38676ca0f743bc95b2a18b8fbc8dd9aa506cd commit 92c38676ca0f743bc95b2a18b8fbc8dd9aa506cd Author: Fredrik Söderquist <fs@opera.com> Date: Mon Aug 13 14:25:43 2018 Update bugrefs for SVG WPT tests from crbug.com/872697 external/wpt/svg/text/reftests/text-multiline-001.svg external/wpt/svg/text/reftests/text-multiline-002.svg external/wpt/svg/text/reftests/text-multiline-003.svg => crbug.com/366558 external/wpt/svg/text/reftests/text-inline-size-001.svg external/wpt/svg/text/reftests/text-inline-size-002.svg external/wpt/svg/text/reftests/text-inline-size-003.svg external/wpt/svg/text/reftests/text-inline-size-005.svg external/wpt/svg/text/reftests/text-inline-size-006.svg external/wpt/svg/text/reftests/text-inline-size-007.svg external/wpt/svg/text/reftests/text-inline-size-101.svg external/wpt/svg/text/reftests/text-inline-size-201.svg => crbug.com/366553 external/wpt/svg/painting/reftests/markers-orient-001.svg => crbug.com/872697 (pending testfix) TBR=schenney@chromium.org BUG=366553,366558, 872697 Change-Id: Ib75f5c0cda767108745618ab508a6a8730e3b1b1 Reviewed-on: https://chromium-review.googlesource.com/1172430 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582576} [modify] https://crrev.com/92c38676ca0f743bc95b2a18b8fbc8dd9aa506cd/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 13
> I'll note that the "[ Linux Win ]" annotations are a bit odd (indicating passes on Mac), so I'd suspect that something might be up with the tests there. That's probably a manifestation of one of the issues blocking issue 433217. (Both of these tests are using Arabic and x/y positioned <tspan>s in the reference image; The Linux [and likely Win] bots have a 1-2 pixel position difference, thus failing the test.)
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c4e24f6030d950b347ccb2fb8ae4392b3f81d7a commit 6c4e24f6030d950b347ccb2fb8ae4392b3f81d7a Author: Fredrik Söderquist <fs@opera.com> Date: Mon Aug 13 15:58:31 2018 Disable 'visual aid' in wpt/svg/painting/reftests/markers-orient-001.svg The test has a red version of the reference painted under the actual test content. Because of how alpha/coverage often work (at least in software rasterizers), this can lead to the read bleeding through and thus affecting the comparison with the reference image. Disable the red reference shapes by adding a CSS rule. This way, if someone feels it's useful for debugging they can easily re-enable it. BUG= 872697 Change-Id: Id47757c9dd112ead0db9c2dcd1adc74d5a52e55d Reviewed-on: https://chromium-review.googlesource.com/1172622 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#582598} [modify] https://crrev.com/6c4e24f6030d950b347ccb2fb8ae4392b3f81d7a/third_party/WebKit/LayoutTests/external/wpt/svg/painting/reftests/markers-orient-001.svg
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1603813c21b4b90fe634a21c046356af867a7e7d commit 1603813c21b4b90fe634a21c046356af867a7e7d Author: Fredrik Söderquist <fs@opera.com> Date: Wed Aug 15 13:07:39 2018 wpt/svg/painting/reftests/markers-orient-001.svg now pass TBR=schenney@chromium.org BUG= 872697 Change-Id: Ib925da7763c4091feacfd489bce1c82c752309ef Reviewed-on: https://chromium-review.googlesource.com/1175796 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#583226} [modify] https://crrev.com/1603813c21b4b90fe634a21c046356af867a7e7d/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 15
Addressed |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by schenney@chromium.org
, Aug 9Owner: schenney@chromium.org
Status: Assigned (was: Untriaged)