New issue
Advanced search Search tips

Issue 872692 link

Starred by 1 user
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Aug 10
Cc:
ajha@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression: Unnecessarily Sign in screen opens along with Sign-in help overlay when 'Learn More' is clicked in Sign out screen

Project Member Reported by rkalavakuntla@chromium.org, Aug 9 
Chrome Version:70.0.3511.0/10952.0.0 dev-channel Gnawty,Falco,Paine
OS:chrome OS

What steps will reproduce the problem?
(1)Sign into user and Sign out 
(2)In sign out screen >>enter a wrong password 
(3)Click on the 'Learn More' link in the wrong password error message and observe

Actual:Unnecessarily Sign in screen opens along with Sign-in help overlay when 'Learn More' link is clicked
Expected:Sign-in screen shouldn't get opened when 'Learn More' link is clicked

This is a Regression issue as same is working fine in 70.0.3505.0/10922.0.0 dev

Attached the screencast for reference..
Actual overlays.jpg
2.4 MB View Download
Expected overlay.jpg
2.6 MB View Download
ACtual.mp4
8.9 MB View Download
Expected.mp4
11.5 MB View Download

Comment 1 by jdufault@chromium.org, Aug 9

Owner: qnnguyen@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/601da7eefcc94358cfc662e260593266d3de750e

commit 601da7eefcc94358cfc662e260593266d3de750e
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Fri Aug 10 17:58:13 2018

cros: Show Account Access help app in its own window instead of OOBE dialog's.

This also fixes the crash when we click on the "Learn More" button in views lock screen.

Bug: 872699,  872692 
Change-Id: I3172cae0a9a86e28a6f154eb000e270eaf9352dd
Reviewed-on: https://chromium-review.googlesource.com/1169764
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582241}
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/chromeos/login/ui/fake_login_display_host.cc
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/chromeos/login/ui/fake_login_display_host.h
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/chromeos/login/ui/login_display_host.h
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/chromeos/login/ui/login_display_host_webui.h
[modify] https://crrev.com/601da7eefcc94358cfc662e260593266d3de750e/chrome/browser/ui/ash/login_screen_client.cc

Comment 3 by qnnguyen@chromium.org, Aug 10

Status: Fixed (was: Assigned)
Should be fixed now.
►

Sign in to add a comment