New issue
Advanced search Search tips

Issue 872691 link

Starred by 1 user
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Aug 13
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Unwanted Focus ring is seen on radio buttons in permission bubble.

Reported by shruti.j...@etouch.net, Aug 9 
Chrome Version:70.0.3516.0 (Official Build) Revision a5cc86ce4806be7adb2876184069510bb6b95057-refs/branch-heads/3516@{#1}(64-bit)
OS:Mac(10.12.6, 10.13.1, 10.13.6, 10.14).

Test URL:https://permission.site

Steps to reproduce:
1.Launch chrome and Navigate to above URL.
2.Click on ‘Allow’ in ‘Auto-download’ permission bubble. (Auto download icon is seen in the omnibox)
3.Click on ‘Auto-download’ icon is seen in omnibox ,Press Tab key in permission bubble of Auto-download in omnibox.
4.Observe Focus on radio-Buttons.

Actual Result:Unwanted Focus ring is seen on radio buttons in permission bubble.
Expected Result:No such focus ring should be seen on radio buttons in permission bubble.

This is a regression issue, broken in 'M-70', and below is per-revision bisect-info:
Good Build:70.0.3515.0(Revision:581085)
Bad Build:70.0.3516.0 (Revision:581409)

You are probably looking for a change made after 581304 (known good), but no later than 581305 (first known bad).
CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/17a922fba5b6ef0e399b3c26b6b21ac49e125502..ad6a740a4670ae50dd2c8226cb9bb4c239682b79

Suspect:https://chromium.googlesource.com/chromium/src/+/ad6a740a4670ae50dd2c8226cb9bb4c239682b79

@Elly Fong-Jones : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the attached screen-cast 
Thank You.
Actual_Result.mov
2.6 MB View Download
Expected_Result.mov
3.2 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b1912e168fdd16c973332d7e59ce3fc784423fb

commit 7b1912e168fdd16c973332d7e59ce3fc784423fb
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Mon Aug 13 18:28:27 2018

views: remove redundant checkbox focus ring

Now that Button has a focus ring, use that instead of creating a second one.

Bug:  872691 
Change-Id: I078a223c491bd83121cf7a488595b26e3c56f81d
Reviewed-on: https://chromium-review.googlesource.com/1172794
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582646}
[modify] https://crrev.com/7b1912e168fdd16c973332d7e59ce3fc784423fb/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/7b1912e168fdd16c973332d7e59ce3fc784423fb/ui/views/controls/button/checkbox.h

Comment 2 by ellyjo...@chromium.org, Aug 13

Status: Fixed (was: Assigned)

Comment 3 by shruti.j...@etouch.net, Aug 14

Labels: TE-Verified-M70 TE-Verified-70.0.3522.0
Update : 
Retested above issue on  Mac(10.12.6, 10.13.1, 10.13.6, 10.14) OS using latest Canary #70.0.3522.0 and issue is fixed.Unwanted focus ring is now not seen on radio buttons in permission bubble.Kindly review the attached screen-cast.
Thank you
Canary_Behaviour#70.0.3522.0.mov
3.4 MB View Download
►

Sign in to add a comment