ARC++ CTS regression on Eve/Soraka due to ozone:drm change |
|||
Issue descriptionHi spang@, Recently we got ARC++ CTS regressions on Eve/Soraka from R70-10934.0.0 https://buganizer.corp.google.com/issues/112341180 After Chrome bisect we've found they are caused from this Chrome change ozone: drm: Move DrmFramebuffer from GbmBuffer to GbmPixmap https://chromium-review.googlesource.com/c/chromium/src/+/1155918 In fact for those ARC++ tests would have imported graphic buffers with invalid AddFramebufferparamterParams where DrmFramebuffer will be failed to create. The following errors could be seen: [14188:14196:0809/171908.051090:ERROR:drm_framebuffer.cc(48)] AddFramebuffer2: Invalid argument (22) It is used to be ok because AddFramebuffersForBo was called on GbmBuffer constructor [1]. After the change, it is called in DrmThread::CreateBufferFromFds and will block created GbmBuffer on failure [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1155918/8/ui/ozone/platform/drm/gpu/gbm_buffer.cc#b84 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/1155918/8/ui/ozone/platform/drm/gpu/drm_thread.cc#266 For passing ARC++ tests, could we set to not fail and block GbmBuffer always for this situation? Or if we could revert temporarily (or not block by AddFrameBuffer failure as before) until we figure out more? Thanks
,
Aug 9
,
Aug 9
Oops, sorry. I thought since gbm_device_is_format_supported() returns true for GBM_BO_USE_SCANOUT we'd always be able to add the framebuffer. https://chromium-review.googlesource.com/c/chromium/src/+/1169595
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ccea48289edb2b94d4b9fc8d6d5f0fcca5437c5 commit 4ccea48289edb2b94d4b9fc8d6d5f0fcca5437c5 Author: Michael Spang <spang@chromium.org> Date: Fri Aug 10 18:26:14 2018 ozone: drm: Allow importing buffers that cannot be added as framebuffers After 6fc38604ad77 ("ozone: drm: Move DrmFramebuffer from GbmBuffer to GbmPixmap"), if a buffer's format is supported for scanout but cannot be added as a framebuffer, we fail the import. This broke CTS tests, so relax this test and add a note. Bug: 872681 Test: ozone_unittests Change-Id: I35e18f043abe21f5554369129da05448f990bfd4 Reviewed-on: https://chromium-review.googlesource.com/1169595 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#582254} [modify] https://crrev.com/4ccea48289edb2b94d4b9fc8d6d5f0fcca5437c5/ui/ozone/platform/drm/gpu/drm_framebuffer.cc [modify] https://crrev.com/4ccea48289edb2b94d4b9fc8d6d5f0fcca5437c5/ui/ozone/platform/drm/gpu/drm_thread.cc
,
Aug 10
|
|||
►
Sign in to add a comment |
|||
Comment 1 by johnylin@chromium.org
, Aug 9