New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 872651 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in !name->AsArrayIndex(&index) in lookup-inl.h

Project Member Reported by ClusterFuzz, Aug 9

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6674100354023424

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !name->AsArrayIndex(&index) in lookup-inl.h
  v8::internal::LookupIterator::LookupIterator
  v8::internal::JSObject::AddProperty
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=54991:54992

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6674100354023424

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 9

Labels: Test-Predator-Auto-Owner
Owner: ftang@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/18246e524da613dca1a64194022601c18a65f85b ([Intl] Move parseExtension from JS to C++).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 9

Labels: Pri-1
Labels: Security_Impact-Head Target-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 10

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
flang: This is a high severity vulnerability, have you had a chance to take a look at your CL? If this can't be fixed quickly the CL should be reverted.
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 23

ftang: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 5

Labels: -Security_Impact-Head Security_Impact-Beta
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 7

ftang: Uh oh! This issue still open and hasn't been updated in the last 29 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Hi @ftang, any movement here? It seems like you are the right owner here, and if you are not, can you assign a better one?
Project Member

Comment 10 by ClusterFuzz, Sep 12

ClusterFuzz has detected this issue as fixed in range 55784:55785.

Detailed report: https://clusterfuzz.com/testcase?key=6674100354023424

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !name->AsArrayIndex(&index) in lookup-inl.h
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=54991:54992
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=55784:55785

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6674100354023424

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Sep 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6674100354023424 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 12

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 14

Labels: Merge-Request-70
Project Member

Comment 14 by sheriffbot@chromium.org, Sep 14

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70
Labels: Merge-Request-70
Looks like this was fixed by https://chromiumdash.appspot.com/commit/c62b0634f3103a0e48d418b2637981c715dfe631 - requesting merge to M70
Project Member

Comment 17 by sheriffbot@chromium.org, Oct 3

Labels: -Merge-Request-70 Merge-Review-70
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org
+abdulsyed@ for merge review
How safe is this merge overall and why is it critical? This seems like a huge change. 
ftang@ - could you speak to the risk of the change? 
Labels: -Target-70 -M-70 -Merge-Review-70 Target-71 M-71
per chat, tracking for M71
Labels: -ReleaseBlock-Stable
Project Member

Comment 23 by sheriffbot@chromium.org, Dec 19

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment