New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872644 link

Starred by 2 users
Status: Fixed
Owner:
kristip...@chromium.org
Closed: Aug 22
Cc:
yyushkina@chromium.org
pnangunoori@chromium.org
kristip...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[NTP] Default focus is not seen on 'Add to shortcut' overlay.

Reported by db...@etouch.net, Aug 9 
Chrome Version: 69.0.3497.32 Revision bf910299d07564d66b36991ebc7dbdc7e26fe897-refs/branch-heads/3497@{#514}(32/64 bit) 
OS: Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS

Pre-condition: Enabled 'Enable using the Google local NTP' and 'New Tab Page Custom Links' flag from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, open NTP and click on 'Add to shortcut' icon from thumbnails section.
(2) Observe default focus.

Actual: Default focus is not seen on 'Add to shortcut' overlay.

Expected: Default focus should seen on 'Add to shortcut' overlay.

This is Non-Regression issue seen from ‘M-69’  as Click event on Gear icon on NTP has implemented from build #69.0.3491.0

Note: Issue is also seen on Canary build #70.0.3517.0
Actual_Focus.mov
2.9 MB View Download

Comment 1 by yyushkina@chromium.org, Aug 9

Labels: -Pri-2 Pri-3
Owner: kristip...@chromium.org

Comment 2 by yyushkina@chromium.org, Aug 13

Cc: kristip...@chromium.org yyushkina@chromium.org
 Issue 873587  has been merged into this issue.

Comment 3 by fgor...@chromium.org, Aug 14

Labels: zine-triaged

Comment 4 by kristip...@chromium.org, Aug 21

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c74a170a470382419eb4df532dd6f62777086c

commit 32c74a170a470382419eb4df532dd6f62777086c
Author: kristipark <kristipark@chromium.org>
Date: Wed Aug 22 18:04:17 2018

[NTP] Focus the Name field when the edit custom link dialog opens

Start the cursor on the name field when the dialog opens. Highlights
any text that is prepopulated in the field.

Bug:  872644 
Change-Id: I9458dec339973ddc9103a3d74a350df0118e8e6d
Reviewed-on: https://chromium-review.googlesource.com/1182305
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585160}
[modify] https://crrev.com/32c74a170a470382419eb4df532dd6f62777086c/chrome/browser/resources/local_ntp/custom_links_edit.js

Comment 6 by kristip...@chromium.org, Aug 22

Status: Fixed (was: Started)

Comment 7 by db...@etouch.net, Aug 24

Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Update:

Tested above issue in latest Canary build #70.0.3532.0 on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) OS and the issue is fixed. 
Hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Actual_Fix.mov
1.5 MB View Download
►

Sign in to add a comment