Remove mojo::Binding in network::URLLoader MojoAsyncResourceHandler |
||
Issue descriptionNow we have CORSURLLoader, so mojo::Binding on that class should be used when OOR-CORS is enabled. I'll define a trivial adapter for the case where the feature is disabled.
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdf9d6d3fd8a088aaa6fb180886fccc09886689a commit fdf9d6d3fd8a088aaa6fb180886fccc09886689a Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Sep 25 06:20:15 2018 OOR-CORS: Use net::ERR_ABORTED on OnConnectionError Currently, some tests expect it does not complete, and others do returning net::ERR_ABORTED. But it's really tough to realize the same behavior when OutOfBlinkCORS is enabled because timing differs. With this fix, CORSURLLoader is changed to return net::ERR_ABORTED on OnConnectionError that happens when a client destructs a loader. Existing tests that expect it does not complete are also modified to check if it does not complete or it completes with the error. This patch will make tests below pass even with OutOfBlinkCORS enabled. - ResourceDispatcherHostTest.DataSentBeforeDetach - ResourceDispatcherHostTest.Cancel - ResourceDispatcherHostTest.DetachedResourceTimesOut - ResourceDispatcherHostTest.TestBlockedRequestsProcessDies - ResourceDispatcherHostTest.TestBlockingCancelingRequests Bug: 872634 , 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2f7f40de49d5820413eaf4e80debf747ba66632a Reviewed-on: https://chromium-review.googlesource.com/1230039 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#593836} [modify] https://crrev.com/fdf9d6d3fd8a088aaa6fb180886fccc09886689a/content/browser/loader/resource_dispatcher_host_unittest.cc [modify] https://crrev.com/fdf9d6d3fd8a088aaa6fb180886fccc09886689a/services/network/cors/cors_url_loader.cc [modify] https://crrev.com/fdf9d6d3fd8a088aaa6fb180886fccc09886689a/services/network/test/test_url_loader_client.h
,
Nov 27
|
||
►
Sign in to add a comment |
||
Comment 1 by yhirano@chromium.org
, Aug 9