New issue
Advanced search Search tips

Issue 872612 link

Starred by 1 user
Status: Duplicate
Merged: issue 870861
Owner:
alex...@chromium.org
Closed: Aug 10
Cc:
iclell...@chromium.org
creis@chromium.org
wfh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SitePerProcessBrowserTest.SameDocumentNavigationDoesNotCommitPendingFramePolicy" flakily timing out

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 9 
"SitePerProcessBrowserTest.SameDocumentNavigationDoesNotCommitPendingFramePolicy" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWgsSBUZsYWtlIk9TaXRlUGVyUHJvY2Vzc0Jyb3dzZXJUZXN0LlNhbWVEb2N1bWVudE5hdmlnYXRpb25Eb2VzTm90Q29tbWl0UGVuZGluZ0ZyYW1lUG9saWN5DA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by pkasting@chromium.org, Aug 9

Cc: creis@chromium.org
Components: UI>Browser>Navigation
Summary: "SitePerProcessBrowserTest.SameDocumentNavigationDoesNotCommitPendingFramePolicy" flakily timing out (was: "SitePerProcessBrowserTest.SameDocumentNavigationDoesNotCommitPendingFramePolicy" is flaky)
Flakiness is the test repeatedly timing out.  Earliest reported flake was in https://build.chromium.org/p/tryserver.chromium.win/builders/win7_chromium_rel_ng/builds/53805 .

Charlie, I know you're going OOO soon -- any chance before then you can redirect this to someone appropriate to investigate?

Leaving in the sheriff queue until this gets an owner.

Comment 2 by creis@chromium.org, Aug 9

Components: Internals>Sandbox>SiteIsolation
Owner: alex...@chromium.org
Status: Assigned (was: Untriaged)
Thanks.  Alex, can you take a look?

Comment 3 by alex...@chromium.org, Aug 10

Cc: iclell...@chromium.org
Here's some output from a run that timed out:

[ RUN      ] SitePerProcessBrowserTest.SameDocumentNavigationDoesNotCommitPendingFramePolicy
DevTools listening on ws://127.0.0.1:49995/devtools/browser/6b0cd1b6-4da0-4335-b432-13548abcb42a
[3492:5020:0809/084835.776:INFO:media_foundation_video_encode_accelerator_win.cc(346)] Windows versions earlier than 8 are not supported.
[5692:4964:0809/084835.795:ERROR:runtime_enabled_features.cc(1573)] RuntimeEnabledFeature not recognized: FeaturePolicyForPermissions
[6048:6100:0809/084835.804:ERROR:runtime_enabled_features.cc(1573)] RuntimeEnabledFeature not recognized: FeaturePolicyForPermissions
[5752:5744:0809/084836.071:ERROR:runtime_enabled_features.cc(1573)] RuntimeEnabledFeature not recognized: FeaturePolicyForPermissions
[6132:5728:0809/084836.166:INFO:CONSOLE(1)] "Throttling history state changes to prevent the browser from hanging.", source:  (1)

The "RuntimeEnabledFeature not recognized: FeaturePolicyForPermissions" also shows up in successful runs (iclelland@, any ideas on what that's about?).  The history state throttling is more suspicious -- maybe one of the same-document navigations in the test is affected by it?  I noticed also that all the flaky runs had a bunch of other failing tests and not only this one, and all the failures had this output.

Comment 4 by alex...@chromium.org, Aug 10

Mergedinto: 870861
Status: Duplicate (was: Assigned)
Ah, I found  issue 870861  which seems to cover this, and this test is one of the failing tests in comment 2 on that bug.  I'll go ahead and merge.

Comment 5 by iclelland@google.com, Aug 10 

FYI, "RuntimeEnabledFeature not recognized: FeaturePolicyForPermissions" appears because that flag has been removed from runtime_enabled_features.json5 (https://crrev.com/d5dc2447), but some test is explicitly trying to enable it by name, either through the command line or the SetFeatureEnabledFromString() interface.

It was stable before, so removing the feature shouldn't have any actual effect.
►

Sign in to add a comment