New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872611 link

Starred by 1 user
Status: Fixed
Owner:
█ digit@chromium.org
Last visit > 30 days ago
Closed: Sep 4
Cc:
agrieve@chromium.org
p...@chromium.org
thakis@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 871418
Blocking:
issue 469376
issue 872503



Sign in to add a comment

Android: Enable ThinLTO for 32-bit ARM builds

Project Member Reported by digit@google.com, Aug 9 
This is a followup to http://crbug.com/871722, where thinLTO were disabled for 32-bit ARM builds, in order to avoid a runtime crash issue, caused by an clang bug.

The bug should be fixed upstream by: https://reviews.llvm.org/D50475

Once tools/clang/scripts/update.py is updated to roll to a version of clang that contains the bug, we should be able to re-enable thinLTO for 32-bit ARM builds.

Comment 1 by thakis@chromium.org, Aug 9

Blocking: 469376

Comment 2 by thakis@chromium.org, Aug 9

Blockedon: 871418
marking blocked on next clang roll

Comment 3 by agrieve@chromium.org, Aug 9

Blocking: 872503
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af7877a78f72c5089e81d2bddcebf763827b8b87

commit af7877a78f72c5089e81d2bddcebf763827b8b87
Author: Peter Collingbourne <pcc@chromium.org>
Date: Fri Aug 31 22:16:35 2018

Revert "android: Disable thinLTO for 32-bit ARM builds."

This reverts commit 069a1be166b09bd5e640d9eebda50bb4a9b4337e.

Reason for revert: Clang roll with the upstream bug fix has landed.

Original change's description:
> android: Disable thinLTO for 32-bit ARM builds.
> 
> This is done to avoid a runtime crash at startup when
> Chrome starts up on devices with a very old Linux kernel.
> 
> This is only one way to address the problem, but probably
> the simplest patch to fix it. See bug entry for all details
> and alternatives considered.
> 
> BUG=871722
> R=​agrieve@chromium.org, pcc@chromium.org, thakis@chromium.org
> 
> Change-Id: I9a197a347538ae9cf9ce6de7b243f522cb425043
> Reviewed-on: https://chromium-review.googlesource.com/1167502
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: David Turner <digit@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581627}

TBR=digit@chromium.org,thakis@chromium.org,pcc@chromium.org,agrieve@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 871722,  872611 
Change-Id: I02d8b5519b978fd61b8cd2ead8718ff77846b402
Reviewed-on: https://chromium-review.googlesource.com/1199937
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588189}
[modify] https://crrev.com/af7877a78f72c5089e81d2bddcebf763827b8b87/build/config/compiler/compiler.gni

Comment 5 by digit@google.com, Sep 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment