Regression: Flickering of contents is seen after pressing down arrow key on chrome background overlay.
Reported by
pranjali...@etouch.net,
Aug 9
|
||||||
Issue descriptionChrome version : 70.0.3516.0 (Official Build) a5cc86ce4806be7adb2876184069510bb6b95057-refs/branch-heads/3516@{#1}(32/64-bit) OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS Steps to reproduce: 1. Launch chrome and open NTP. 2. Click on 'Gear' icon and click on 'chrome backgrounds' . 3. Now press 'down arrow' button and observe. Actual Result:Flickering of contents is seen after pressing down arrow key on chrome background overlay. Expected Result:Flickering of contents should not be seen after pressing down arrow key on chrome background overlay. This is a regression issue broken in ‘M-70’ and below is bisect info. Good build: 70.0.3503.0 Bad build: 70.0.3504.0 You are probably looking for a change made after 578169 (known good), but no later than 578170 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7637ae87b8e8ef651fdcd15e8ace6da78053e6b0..b315c20043e0a5ad29ed29ce7d47aaba043b8204 Suspect: https://chromium.googlesource.com/chromium/src/+/b315c20043e0a5ad29ed29ce7d47aaba043b8204 @kmilka: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You
,
Aug 9
,
Aug 10
Just want to make sure... The "Expected Result" is not what we want right? The arrow key should focus on the tile and then navigate the tile instead of just scroll up and down the scrollbar. Please see the screencast for what I have now. wdyt? https://screencast.googleplex.com/cast/NTM4MjY0MzkzMTY3NjY3MnwxMTIwOGY4NS1iNA
,
Aug 10
Hey Weilun: that's right, the existing behavior that we have on Canary now just with the jumping/flickering fixed would be what we want.
,
Aug 10
Talking offline with Weilun, there's a bit of concern that this will break other aspects of the navigation. We'll revisit this later in the M71 timeframe, but focusing on other bugs first.
,
Aug 10
Sorry, later in the M70 timeframe :)
,
Aug 14
,
Aug 23
The screencast actually looks ok to me - does voiceover still read the group, and then the individual title collections?
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdfd0835f3bb7598748a5eff0b1ec368b64f0eb1 commit cdfd0835f3bb7598748a5eff0b1ec368b64f0eb1 Author: Weilun Shi <sweilun@chromium.org> Date: Fri Aug 24 18:37:57 2018 [NTP] Fix flickering issue on custom background dialog This CL modify a few event listener, using keydown event instead of keyup event making the arrow key interaction between tiles will not propagate to the menu. With this CL, when hitting arrow key on the tile will not move the scroll unless it has to eg. the next focus item located outside the current viewpoint. Screencast: https://screencast.googleplex.com/cast/NDgzNTA4MjMwOTIwNjAxNnw5NjFlYmFkZC0zNA Bug: 872601 Change-Id: I352a28dbc0a05779818ee27fd9df563114caf6c2 Reviewed-on: https://chromium-review.googlesource.com/1187236 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#585917} [modify] https://crrev.com/cdfd0835f3bb7598748a5eff0b1ec368b64f0eb1/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Aug 24
This CL will not change the current behavior for screen readers. Now, when you press the arrow key, it will quick scan through the tiles in that direction instead of only making one change when you release the the arrow key.
,
Aug 24
,
Aug 27
Update: Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) OS using latest canary build #70.0.3534.0 and issue is fix. Flickering of contents is not seen on pressing down arrow key. Please find attached screencast for reference. Thank You...
,
Sep 10
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ramyan@chromium.org
, Aug 9Labels: -Pri-1 Pri-2
Owner: sweilun@chromium.org