New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872584 link

Starred by 1 user
Status: Duplicate
Owner:
mlippautz@chromium.org
Closed: Aug 13
Cc:
wutao@chromium.org
morlovich@chromium.org
tangltom@chromium.org
█ jialiul@chromium.org
toyoshim@chromium.org
mamir@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

11.5%-40.3% regression in blink_perf.bindings at 580866:580951

Project Member Reported by toyoshim@chromium.org, Aug 9 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Aug 9 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=872584

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b04a2a96ba1f80ecef296b2b129530a9f7bff9236d06e9af46c84e555a06a5cb


Bot(s) for this bug's original alert(s):

Android Nexus5 Perf
mac-10_12_laptop_low_end-perf
mac-10_13_laptop_high_end-perf
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 12

Cc: wutao@chromium.org jialiul@chromium.org mamir@chromium.org mlippautz@chromium.org tangltom@chromium.org mmenke@chromium.org morlovich@chromium.org
Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 7 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/16dcc68c640000

[bindings,heap] Prepare PerIsolateData for holding different heap tracer by mlippautz@chromium.org
https://chromium.googlesource.com/chromium/src/+/1186c664d583e43a45f365d4a5291bed032542bd
4328 → 6106 (+1779)

[unified-consent] Add metric ConsentBump.SuppressReason by tangltom@chromium.org
https://chromium.googlesource.com/chromium/src/+/bd267f310bdc6289fec1186a32eddeac8595e491
6116 → 6271 (+154.7)

Reland "Reland "[Sync::USS] Bookmark sync conflict resolution"" by mamir@chromium.org
https://chromium.googlesource.com/chromium/src/+/88d36bfc24217797bc22f6f164cf1293c57d449b
6303 → 6046 (-256.4)

Fix double-delete in ResolveProxyMsgHelper. by mmenke@chromium.org
https://chromium.googlesource.com/chromium/src/+/5491b007536cc28a362643d9c27bbb0080959091
5976 → 5800 (-176.5)

Drop incognito profiles in-memory browser cache when memory gets low. by morlovich@chromium.org
https://chromium.googlesource.com/chromium/src/+/1c884a7919e5ec639d7950e8d7958e4165930fc3
5800 → 6213 (+413.1)

Revert "Add assistant audio decoder" by wutao@chromium.org
https://chromium.googlesource.com/chromium/src/+/84ecb1d1b075243b7d83219bd8cb264486d16c32
6213 → 6125 (-88)

Retrieve advanced protection bit from ID token (Non-CrOS desktop chrome) by jialiul@chromium.org
https://chromium.googlesource.com/chromium/src/+/7370efa1534956eb0abed336b20b6334224292db
6125 → 5888 (-237.2)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by mmenke@chromium.org, Aug 12

Cc: -mmenke@chromium.org
My crash fix only affects an obscure API used by crash, an just affects its refcount, so...Not mine.

Comment 5 by jialiul@chromium.org, Aug 12

Owner: ----
Status: Available (was: Assigned)
My change didn't touch pref at all.

Comment 6 Deleted

Comment 7 by mamir@chromium.org, Aug 12 

My change is behind a feature flag and not enabled yet.
It shouldn't be mine.

Comment 8 by mlippautz@chromium.org, Aug 13

Cc: -mlippautz@chromium.org
Mergedinto: 872581
Owner: mlippautz@chromium.org
Status: Duplicate (was: Available)
fyi: Pinpoint clearly identifies 1186c664d583e43a45f365d4a5291bed032542bd as culprit. There's no need for speculation.

This has been reverted in b91727ed05b24be7deb008112b0de5ab7d807414.
►

Sign in to add a comment