New issue
Advanced search Search tips

Issue 872567 link

Starred by 1 user
Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove unneeded service worker histograms.

Project Member Reported by falken@chromium.org, Aug 9 
We have many histograms added per service worker event. In some cases we have an n*m pattern like StartWorker.Time_(situation)_(event_type).

We also have histograms we probably don't really use like EventDispatchDelay.

In most cases we really only cared about the metric for certain event types like notificationclick and fetch. We don't have to be so generic and can save memory by removing unneeded metrics.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61e4323a7f100030e5434aeee915ef226c5fe6b1

commit 61e4323a7f100030e5434aeee915ef226c5fe6b1
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Thu Nov 01 01:37:24 2018

Remove ServiceWorker.EventDispatchingDelay histograms

Two reasons to remove these histograms:
- We haven't been looking at these histograms.
- We added milestone-style histograms for main/sub resource loading
  and some of these track event dispatching delays.

Bug: 898020, 872567
Change-Id: I9f61da0101aa8e38ff4bca519126ef339b877863
Reviewed-on: https://chromium-review.googlesource.com/c/1307015
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604475}
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_metrics.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_metrics.h
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_registration_unittest.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/61e4323a7f100030e5434aeee915ef226c5fe6b1/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbf5b85e52e92195989215ff4c206d4b46c5cfcf

commit bbf5b85e52e92195989215ff4c206d4b46c5cfcf
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Tue Nov 06 23:43:37 2018

Service Worker: Remove event dispatching delay parameters

This is a follow-up CL of https://crrev.com/c/1307015.
We don't use |dispatch_event_time| any longer.

Change-Id: If14e295eb6c0a8d9b83f499e3b7f65d4ff6d1d27
Bug: 898020, 872567
Reviewed-on: https://chromium-review.googlesource.com/c/1319398
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605877}
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/background_fetch/background_fetch_embedded_worker_test_helper.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/cookie_store/cookie_store_manager_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/payments/payment_app_content_unittest_base.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/payments/payment_app_provider_impl.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/embedded_worker_test_helper.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_browsertest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_context_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_fetch_dispatcher.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_fetch_dispatcher.h
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_job_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_navigation_loader_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_object_host_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_register_job.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_register_job.h
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_url_request_job_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/browser/service_worker/service_worker_version_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/common/service_worker/controller_service_worker.mojom
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/common/service_worker/service_worker.mojom
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/renderer/service_worker/service_worker_context_client_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/renderer/service_worker/service_worker_subresource_loader.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/renderer/service_worker/service_worker_subresource_loader.h
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/content/renderer/service_worker/service_worker_subresource_loader_unittest.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/public/mojom/payments/payment_app.mojom
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/public/web/modules/service_worker/web_service_worker_context_client.h
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/renderer/modules/payments/abort_payment_respond_with_observer.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/renderer/modules/payments/can_make_payment_respond_with_observer.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/renderer/modules/payments/payment_request_respond_with_observer.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/renderer/modules/service_worker/service_worker_global_scope_client.h
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/renderer/modules/service_worker/wait_until_observer.cc
[modify] https://crrev.com/bbf5b85e52e92195989215ff4c206d4b46c5cfcf/third_party/blink/renderer/modules/service_worker/wait_until_observer.h
►

Sign in to add a comment