New issue
Advanced search Search tips

Issue 872557 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 17
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug

Blocked on:
issue 876148



Sign in to add a comment

ios_internal_chrome_external_url failing intestWebReferrerOpenInNewTab and testWebReferrerNavigation on iOS12

Project Member Reported by justincohen@chromium.org, Aug 9

Issue description

Both tests are failing on iOS12.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/cea4edcb99e2b4071fb53fb26ce9437bd97338b0

commit cea4edcb99e2b4071fb53fb26ce9437bd97338b0
Author: Justin Cohen <justincohen@google.com>
Date: Thu Aug 09 04:16:13 2018

Labels: -Pri-3 Pri-1
testWebReferrerNavigation and testWebReferrerOpenInNewTab work fine on iOS 12.0 (16A5327d) simulator when run locally. Will try enabling the test to run on bots.
Blockedon: 876148
Per comment 3 on crbug/876148, please confirm *this* bug is not a product issue. If not this can also be punted to M71 RBB.
Cc: kariahda@chromium.org
testWebReferrerOpenInNewTab and testWebReferrerNavigation are change detector tests. WebKit behavior has changed and we need more time to understand if the change is correct. Having said that even if new behavior is not correct, that can't be fixed in Chrome.

I think it's ok to remove RBB. 
Labels: -ReleaseBlock-Beta
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/8b7f22e8c9e6bcba27d673433bf9e5c9cbbd0b3b

commit 8b7f22e8c9e6bcba27d673433bf9e5c9cbbd0b3b
Author: Eugene But <eugenebut@google.com>
Date: Mon Sep 17 21:17:46 2018

Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/bd3ef963ac86f9901c437de486dbb59b0a5e9d0e

commit bd3ef963ac86f9901c437de486dbb59b0a5e9d0e
Author: Mike Dougherty <michaeldo@google.com>
Date: Fri Oct 19 21:27:10 2018

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 24

Labels: Merge-Merged-3578
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/9d76b724af6de45a384ee164dd59c4617a411a2f

commit 9d76b724af6de45a384ee164dd59c4617a411a2f
Author: Mike Dougherty <michaeldo@google.com>
Date: Wed Oct 24 17:43:09 2018

Sign in to add a comment