Snap an arc app from top should not become maximized first |
||
Issue descriptionWhat steps will reproduce the problem? (1) Drag an arc app from top to snap it into splitview. What is the expected result? Window should change from its current transform to final bounds of the snapped window. What happens instead? The arc window became maximized first and then the size of the snapped window.
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96202134de7888d656d60d8d04752ea6f9f94c4d commit 96202134de7888d656d60d8d04752ea6f9f94c4d Author: Min Chen <minch@google.com> Date: Fri Aug 24 22:45:50 2018 Defer resetting identity transform of the drag window from top until it has been snapped. We did defer resetting the transform to identity of the drag window from overview items until it has been snapped. In order to avoid the weird transform if trying to snap an arc window. Previous cl: https://chromium-review.googlesource.com/c/chromium/src/+/910076 We should do the same thing if we try to snap a window through drag from the top. Changes in this cl, - Do not restore the drag window's transform to identity when end window drag if the window should be snapped or drop into overview. - Restore identity transform after window has been snapped. Calculate a starting transform for the to-be-snapped window based on its transformed bounds before to be snapped. - Move the logic of GetTransformedBounds and GetTopInset to overview_util. Bug: 872538 Change-Id: Icc2f034e0752fba4ba8ec673022e1f9306ca35b2 Reviewed-on: https://chromium-review.googlesource.com/1178385 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#586030} [modify] https://crrev.com/96202134de7888d656d60d8d04752ea6f9f94c4d/ash/wm/overview/overview_utils.cc [modify] https://crrev.com/96202134de7888d656d60d8d04752ea6f9f94c4d/ash/wm/overview/overview_utils.h [modify] https://crrev.com/96202134de7888d656d60d8d04752ea6f9f94c4d/ash/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/96202134de7888d656d60d8d04752ea6f9f94c4d/ash/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/96202134de7888d656d60d8d04752ea6f9f94c4d/ash/wm/splitview/split_view_controller.cc [modify] https://crrev.com/96202134de7888d656d60d8d04752ea6f9f94c4d/ash/wm/splitview/split_view_controller.h [modify] https://crrev.com/96202134de7888d656d60d8d04752ea6f9f94c4d/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc
,
Aug 24
|
||
►
Sign in to add a comment |
||
Comment 1 by minch@chromium.org
, Aug 16