Minimum transform of the dragged window from top is too large |
|||||
Issue descriptionThe minimum transform of the dragged window is still a little bit large. Keep it the same as if start to drag a window in overview mode, 1. Enter the overview mode, 2. Press a selected window for a while, 3. The window will become a little bit larger (120% of without header) before it becomes drag-gable. Keep the minimum transform of the dragged window from top the same as it in above state.
,
Aug 13
,
Aug 13
,
Aug 13
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/168e8dce30556ad4e2e18c373941ecefd4c0f23b commit 168e8dce30556ad4e2e18c373941ecefd4c0f23b Author: Min Chen <minch@google.com> Date: Mon Aug 20 18:59:36 2018 Consolidate size of the drag window from top or from overview items. The size of dragging window used to be different depending on how dragging started. It was bigger when you drag from the top compared to when you drag from overview items. This CL consolidate two into the same size, to the size used when dragged from overview items. see recorded video: https://drive.google.com/file/d/0B5I0jFeLxqIiNThBNU1sbVRTRUgyZmRUNUpxdVI2WVRsSHBj/view?usp=sharing Bug: 872528 Change-Id: I778fdb871556ec960b4d8fdffd1f608c19a01148 Reviewed-on: https://chromium-review.googlesource.com/1173158 Reviewed-by: Mitsuru Oshima (Slow) <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#584521} [modify] https://crrev.com/168e8dce30556ad4e2e18c373941ecefd4c0f23b/ash/wm/overview/overview_window_drag_controller.cc [modify] https://crrev.com/168e8dce30556ad4e2e18c373941ecefd4c0f23b/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/168e8dce30556ad4e2e18c373941ecefd4c0f23b/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/168e8dce30556ad4e2e18c373941ecefd4c0f23b/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.cc [modify] https://crrev.com/168e8dce30556ad4e2e18c373941ecefd4c0f23b/ash/wm/tablet_mode/tablet_mode_window_drag_delegate.h
,
Aug 20
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7513253951e302452d123dc27c169ca3948afb89 commit 7513253951e302452d123dc27c169ca3948afb89 Author: Min Chen <minch@google.com> Date: Thu Aug 23 19:02:10 2018 Do not actually scale up new selector item in overview. Because of this cl https://chromium-review.googlesource.com/c/chromium/src/+/1173158 The new selector item will be scaled up when we start drag a window from top. But actually we just want to get the bounds of the scaled up new selector item, we don't actually want to scaled it up in this case. Bug: 872528 Change-Id: I4d132680ed35440eb5873620412fba1931db1857 Reviewed-on: https://chromium-review.googlesource.com/1182799 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585568} [modify] https://crrev.com/7513253951e302452d123dc27c169ca3948afb89/ash/wm/overview/window_selector_item.cc [modify] https://crrev.com/7513253951e302452d123dc27c169ca3948afb89/ash/wm/overview/window_selector_item.h [modify] https://crrev.com/7513253951e302452d123dc27c169ca3948afb89/ash/wm/splitview/split_view_controller_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by minch@chromium.org
, Aug 13