Issue metadata
Sign in to add a comment
|
llvm-next: cleanup confusing patches |
||||||||||||||||||||||
Issue descriptionllvm ebuild file contains the following comment: # This is need by thinlto on ARM. # Convert to cherry-picks once # https://reviews.llvm.org/D44788 gets merged # Note: D44788 was already merged but this is still needed. # See crosbug/ epatch "${FILESDIR}"/clang-7.0-flto-fission.llvm-next.patch however, D44788 was merged as r335546. And the ebuild is already picking that cherry. So what is going on with this patch and comment? Please cleanup.
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e20d28b2534d24c7c1a30b30a8509a05782e8586 commit e20d28b2534d24c7c1a30b30a8509a05782e8586 Author: Yunlian Jiang <yunlian@google.com> Date: Thu Sep 13 13:14:19 2018 llvm: remove an unneccssary patch. The patch clang-7.0-flto-fission.llvm-next.patch enabled debug fission on thinlto with flag -glto-dwo-dir. However, upstream uses the flag -gsplit-dwarf instead. We used the upstream flag in chromeos-chrome ebuild already, so these is no need to keep this patch any more. BUG= chromium:872525 TEST=sudo emerge llvm builds. Change-Id: If834be4661105bdb64efea1468b075f1f463ce55 Reviewed-on: https://chromium-review.googlesource.com/1220093 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> [rename] https://crrev.com/e20d28b2534d24c7c1a30b30a8509a05782e8586/sys-devel/llvm/llvm-7.0_pre333878_p20180808-r5.ebuild [delete] https://crrev.com/1519043ba14154ca0828dd7551fec5723edc7421/sys-devel/llvm/files/clang-7.0-flto-fission.llvm-next.patch [modify] https://crrev.com/e20d28b2534d24c7c1a30b30a8509a05782e8586/sys-devel/llvm/llvm-7.0_pre333878_p20180808.ebuild
,
Sep 13
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by llozano@chromium.org
, Aug 9