New issue
Advanced search Search tips

Issue 872524 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Context menu has gray text with too low of contrast

Project Member Reported by leberly@chromium.org, Aug 9

Issue description

Google Chrome	70.0.3514.0 (Official Build) dev (64-bit) (cohort: Dev)
Windows 10

If you invoke the context menu on any part of the chrome (tab strip, Omnibox, extensions, bookmarks bar, etc.) or on a webpage and the grayed out text is too low of contrast. See screenshot. 

You can invoke the context menu by right clicking or by pressing the context key. 

Foreground:#A1A192
Background:#FFFFFF

The contrast ratio is: 2.6:1

 
contextmenucontrast.png
5.7 KB View Download
Labels: a11y-Bookmarks
Also applies to Chrome OS
Google Chrome	70.0.3511.0 (Official Build) canary (64-bit)
Firmware Version Google_Eve.9584.160.0	

You can right click with the keyboard-only using ctrl + search + volume up
Labels: OS-Chrome
Labels: -a11y-Bookmarks a11y-WebUI
https://cs.chromium.org/chromium/src/ui/native_theme/native_theme.h?type=cs&sq=package:chromium&g=0&l=317 seems like a decent place to start - this seems like a system-wide issue, is there a bug for the context menu?
Labels: pm-markchang
Labels: pm-markchang
Isn't this WAI though, if it's text that is disabled and therefore not actionable? I'd like to see it slightly darker, but wouldn't want to make it confusing for users if it's too dark and then looks clickable. 
Labels: contrast
Labels: needs-ux
Labels: Group-Secondary_UI
Labels: -Group-Secondary_UI Group-Views_Platform
Owner: kylixrd@chromium.org
Status: Assigned (was: Available)
Staging on kylixrd@ for Product Excellence phase.
Owner: robliao@chromium.org
Reassigning to robliao@ for cross team footwork.
We lgtm'ed Google Grey 600 on an offline thread. Patch coming soon.
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cebe24d76e6eeb89c5820b7b1a2da067b16692b

commit 4cebe24d76e6eeb89c5820b7b1a2da067b16692b
Author: Robert Liao <robliao@chromium.org>
Date: Fri Nov 30 02:30:18 2018

Increase Disabled Text Contrast of Menus, Buttons, and Textfields

From the available palette, this is the closest we can get to 4 without
making the text actually look enabled.

The contrast ratio of menus and textfields go from 2.61 to 3.68 and
the contrast ratio of buttons go from 2.54 to 3.54.

BUG= 872524 
TBR=pkasting@chromium.org
Color change with accessibility approval.

Change-Id: I3d5c917d5b4be193a78e950d021d97dceb4ab15d
Reviewed-on: https://chromium-review.googlesource.com/c/1353947
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612527}
[modify] https://crrev.com/4cebe24d76e6eeb89c5820b7b1a2da067b16692b/ui/native_theme/common_theme.cc

Status: Fixed (was: Assigned)

Sign in to add a comment