[Findit] Flake Analyzer - Not all builds fully on LUCI yet |
||
Issue descriptionseveral flake analyses still can't run due to failure to find IsolatedTargets for commit position -> isolate hash. This is due to a few builders still being on buildbot instead of LUCI, and the number is > 5% so fallback to searching buildbot (as before) is still needed. The estimated schedule is to have all public builders on LUCI by end of Q3, to start reducing support for anything buildbot related by end of Q4, and official buildbot cutoff by Q1 2019
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/ea0966b8e62bb4b687ff608696eb52f5127376d9 commit ea0966b8e62bb4b687ff608696eb52f5127376d9 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Fri Aug 10 21:10:02 2018 [Findit] Flake Analyzer - Implementing fallback logic when mapping commit position -> nearby builds in NextCommitPositionPipeline Not all builders are on LUCI yet, and thus flake analysis would fail when trying to map a commit position to an IsolatedTarget. In order to get build shas to trigger swarming tasks against for all builds supported for analysis, fallback to searching buildbot for nearby builds when IsolatedTargets are unavailable. This is a temporary workaround until all builds have been migrated to LUCI, and this CL can be reverted or an inverse manually created. Bug: 872515 Change-Id: Id1063b158b716f47cb8b3257162fc2191bf1c827 Reviewed-on: https://chromium-review.googlesource.com/1170358 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> [modify] https://crrev.com/ea0966b8e62bb4b687ff608696eb52f5127376d9/appengine/findit/pipelines/flake_failure/next_commit_position_pipeline.py [modify] https://crrev.com/ea0966b8e62bb4b687ff608696eb52f5127376d9/appengine/findit/model/flake/master_flake_analysis.py [modify] https://crrev.com/ea0966b8e62bb4b687ff608696eb52f5127376d9/appengine/findit/model/flake/test/master_flake_analysis_test.py [modify] https://crrev.com/ea0966b8e62bb4b687ff608696eb52f5127376d9/appengine/findit/pipelines/flake_failure/test/next_commit_position_pipeline_test.py
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/984dc534e50f533ae9d28ea81ac5e98dfdb9c9a6 commit 984dc534e50f533ae9d28ea81ac5e98dfdb9c9a6 Author: Jeffrey Li <lijeffrey@chromium.org> Date: Mon Aug 13 18:00:59 2018 [Findit] Flake Analyzer - Fallback to buildbot if no isolated target in GetIsolateShaPipeline As not all builders are on LUCI yet, using IsolatedTarget will not work for some flake analyses. This change implements fallback logic to searching buildbot when mapping commit positions to nearby builds within GetIsolateShaPipeline. Bug: 872515 Change-Id: I4b1ee7e17b38982269b28a474b97792b9cf6a129 Reviewed-on: https://chromium-review.googlesource.com/1170181 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> [modify] https://crrev.com/984dc534e50f533ae9d28ea81ac5e98dfdb9c9a6/appengine/findit/pipelines/flake_failure/test/get_isolate_sha_pipeline_test.py [modify] https://crrev.com/984dc534e50f533ae9d28ea81ac5e98dfdb9c9a6/appengine/findit/pipelines/flake_failure/get_isolate_sha_pipeline.py
,
Sep 10
|
||
►
Sign in to add a comment |
||
Comment 1 by lijeffrey@chromium.org
, Aug 10