New issue
Advanced search Search tips

Issue 872509 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 754101


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

[Harmony Cast Dialog] Disable sinks incompatible with the selected source

Project Member Reported by taku...@chromium.org, Aug 8

Issue description

When we allow the user to cast by clicking on a sink, we must disallow casting to a sink incompatible with the source chosen by the source picker. The source picker will now always contain all the sources.
 
Blocking: 754101
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2128f0940edf5b91bc2ddc85245f8d14f1b9de77

commit 2128f0940edf5b91bc2ddc85245f8d14f1b9de77
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Aug 16 01:54:48 2018

[Harmony Cast Dialog] Disable sinks incompatible with the selected source

In a future CL, we will be removing the "Cast" button in the dialog
and enabling the user to start casting just by clicking on a sink. This
CL is in preparation for that.

Currently, the source list only shows sources supported by the currently
selected sink. This CL makes the list show all the sources. When a source
is selected, we disable buttons for sinks that do not support the source.

The visual design for disabled sinks is TBD; the icon/text are greyed out
for now.

Bug:  872509 

Change-Id: I5ba719d08dd85e2b8915da22d0a2b22988b4f384
Reviewed-on: https://chromium-review.googlesource.com/1166341
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583492}
[modify] https://crrev.com/2128f0940edf5b91bc2ddc85245f8d14f1b9de77/chrome/browser/ui/views/hover_button.cc
[modify] https://crrev.com/2128f0940edf5b91bc2ddc85245f8d14f1b9de77/chrome/browser/ui/views/hover_button.h
[modify] https://crrev.com/2128f0940edf5b91bc2ddc85245f8d14f1b9de77/chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc
[modify] https://crrev.com/2128f0940edf5b91bc2ddc85245f8d14f1b9de77/chrome/browser/ui/views/media_router/cast_dialog_sink_button.h
[modify] https://crrev.com/2128f0940edf5b91bc2ddc85245f8d14f1b9de77/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/2128f0940edf5b91bc2ddc85245f8d14f1b9de77/chrome/browser/ui/views/media_router/cast_dialog_view.h
[modify] https://crrev.com/2128f0940edf5b91bc2ddc85245f8d14f1b9de77/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment