New issue
Advanced search Search tips

Issue 872508 link

Starred by 1 user
Status: Fixed
Owner:
masonfreed@chromium.org
Closed: Aug 23
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Replace (most) calls to LayoutObject.Style() with a call to LayoutObject.StyleRef() instead

Project Member Reported by masonfreed@google.com, Aug 8 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Example URL:
N/A

Steps to reproduce the problem:
Especially within paint, most calls to LayoutObject.Style() are assuming a non-null pointer and dereferencing it. To better document the fact that these calls (properly, in most cases) assume the layout object contains style, they should be replaced with calls to the StyleRef() function, which dereferences the pointer.

What is the expected behavior?

What went wrong?
Code cleanup, nothing broken that I know of.

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 68.0.3440.106  Channel: stable
OS Version: OS X 10.13.6
Flash Version: 

I'm a new chromium developer, and I don't have an @chromium account yet. Hopefully I'm entering this bug in the right place!

Comment 1 by chrishtr@chromium.org, Aug 8

Components: -Blink Blink>Layout Blink>Paint
Owner: chrishtr@chromium.org
Status: Started (was: Unconfirmed)
masonfreed@ is working on it.

Comment 2 by masonfreed@chromium.org, Aug 9

Owner: masonfreed@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95e719856c142dd807b287f535e3a597c3112e5e

commit 95e719856c142dd807b287f535e3a597c3112e5e
Author: Mason Freed <masonfreed@google.com>
Date: Fri Aug 10 23:14:29 2018

Replaced calls to LayoutObject.Style() with LayoutObject.StyleRef().

Especially within paint, most calls to LayoutObject.Style() are assuming a non-null pointer and
dereferencing it. To better document the fact that these calls (properly, in most cases)
assume the layout object contains style, they should be replaced with calls to the StyleRef()
function, which dereferences the pointer.

Bug:  872508 
Change-Id: Id6a04871c12a2c09d1029ca5aa04ae49099f7fd0
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1171144
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@google.com>
Cr-Commit-Position: refs/heads/master@{#582380}
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/block_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/box_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/collapsed_border_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/css_mask_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/details_marker_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/fieldset_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/file_upload_control_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/inline_flow_box_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/inline_text_box_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/link_highlight_impl.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/list_marker_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/multi_column_set_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/paint_layer.h
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/root_inline_box_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/scrollable_area_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/svg_image_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/svg_inline_text_box_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/svg_model_object_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/svg_shape_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/table_cell_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/table_painter.cc
[modify] https://crrev.com/95e719856c142dd807b287f535e3a597c3112e5e/third_party/blink/renderer/core/paint/view_painter.cc

Comment 4 by masonfreed@chromium.org, Aug 10

Status: Fixed (was: Started)
Implemented, for all code in the paint folder.

Comment 5 by masonfreed@chromium.org, Aug 20

Status: Started (was: Fixed)
Re-opening this bug - per chrishtr@, I'm expanding the scope to more directories. 

New CL in progress here:
https://chromium-review.googlesource.com/c/chromium/src/+/1182185
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fe4904a00ba85fe97d3b64dee683803e8d8049b

commit 3fe4904a00ba85fe97d3b64dee683803e8d8049b
Author: Mason Freed <masonfreed@chromium.org>
Date: Thu Aug 23 15:21:18 2018

[CI] More replacments of calls to LayoutObject.Style() with LayoutObject.StyleRef()

This continues the work done in https://chromium-review.googlesource.com/c/chromium/src/+/1171144,
this time expanding the set of folders considered for replacement, and the scope of the replacements.
With this CL, I believe I have replaced most references to Style() with StyleRef() within
these folders:
 - paint
 - layout
 - svg
 - frame

Note that I only replaced immediate uses of Style(), i.e. Style()->Xyz. These are guaranteed not to
cause any breakage (assuming I did the replacement well) because they already dereferenced the
pointer. There are many references to Style() where the result is first checked, or where
the actual pointer is passed around, and I have not touched those (yet). Perhaps for a later CL.

I have also consciously not modified code in other folders (including animation, css, dom, editing, exported,
html, input, layout/ng, page, and style). The reason I skipped these is that, at least for now, I
am not sure that Style can always safely be assumed to be available (non-null). There are definitely
cases where that can be inferred, but I didn't want to change some references in a folder and not others.
Perhaps for a later CL.

Bug:  872508 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie2293901477ef3ed8912582d206bdaac8fd000e1
Reviewed-on: https://chromium-review.googlesource.com/1182185
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585491}
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/frame/link_highlights.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/frame/root_frame_viewport.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/frame/smart_clip.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/api/line_layout_item.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/bidi_run_for_line.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/flexible_box_algorithm.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/flexible_box_algorithm.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/floating_objects.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/hit_test_result.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_analyzer.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_block.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_block.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_block_flow.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_block_flow_line.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_box.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_box_model_object.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_box_model_object.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_button.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_counter.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_deprecated_flexible_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_deprecated_flexible_box.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_details_marker.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_embedded_content.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_embedded_object.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_fieldset.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_file_upload_control.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_flexible_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_frame.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_frame_set.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_geometry_map.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_grid.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_html_canvas.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_iframe.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_inline.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_list_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_list_item.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_list_marker.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_menu_list.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_multi_column_flow_thread.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_multi_column_set.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_multi_column_spanner_placeholder.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_object.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_paged_flow_thread.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_progress.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_quote.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_replaced.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_replaced.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_ruby_run.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_ruby_text.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_scrollbar_part.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_slider.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_slider_container.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_state.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_box_component.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_cell.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_cell.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_col.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_col.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_row.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_row.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_table_section.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_text.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_text.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_text_combine.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_text_combine.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_text_control.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_text_control_single_line.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_tree_as_text.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_video.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_view.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/layout_vtt_cue.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/abstract_inline_text_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/breaking_context_inline_headers.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/inline_flow_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/inline_flow_box.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/inline_iterator.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/inline_text_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/line_box_list.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/line_breaker.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/line_width.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/line/root_inline_box.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/multi_column_fragmentainer_group.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/order_iterator.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/scroll_anchor.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/shapes/shape_outside_info.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_block.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_container.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_ellipse.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_inline_text.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_model_object.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_rect.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_resource_masker.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_root.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_shape.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_shape.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/layout_svg_text.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/svg_layout_support.h
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/svg_layout_tree_as_text.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/svg_text_layout_engine_baseline.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/svg/svg_text_query.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/table_layout_algorithm_auto.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/table_layout_algorithm_fixed.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/text_autosizer.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/layout/text_autosizer_test.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/paint/compositing/compositing_layer_assigner.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/paint/compositing/compositing_requirements_updater.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/paint/inline_text_box_painter.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/paint/svg_inline_text_box_painter.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/svg/graphics/svg_image.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/svg/svg_fe_diffuse_lighting_element.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/svg/svg_fe_drop_shadow_element.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/svg/svg_fe_flood_element.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/svg/svg_fe_specular_lighting_element.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/svg/svg_geometry_element.cc
[modify] https://crrev.com/3fe4904a00ba85fe97d3b64dee683803e8d8049b/third_party/blink/renderer/core/svg/svg_svg_element.cc

Comment 7 by masonfreed@chromium.org, Aug 23

Status: Fixed (was: Started)
►

Sign in to add a comment