New issue
Advanced search Search tips

Issue 872500 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 863631



Sign in to add a comment

cq: add_unique_comment is broken

Project Member Reported by tandrii@chromium.org, Aug 8

Issue description

Added debug lines in https://chrome-internal-review.googlesource.com/660964 
Tested on https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/660963

Relevant log:
D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:559] add_unique_comment_per_run "Your CL relies on deprecated CQ feature(s):
* Private CLs will soon be rejected by CQ (except in Dry Run).
Please, change your CL visibility before submitting to CQ.
For more details, see  https://crbug.com/863631 " timestamp 2018-08-08 22:41:57+00:00 

...
D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:563] too early 2018-08-08 22:19:37+00:00 Patch Set 1:
lol, turns out tryjobs don't work with private CLs either, because they can't detect the destination gerrit branch. 
D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:570] no match Patch Set 1: Commit-Queue+2 stamp 2018-08-08 22:41:57+00:00 
D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:570] no match Patch Set 1:
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.....


D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:570] no match Patch Set 1:
Your CL relies on deprecated CQ feature(s):
* Private CLs will soon be rejected by CQ (except in Dry Run).
Please, change your CL visibility before submitting to CQ.
For more details, see  https://crbug.com/863631  stamp 2018-08-08 22:42:07+00:00 


D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:570] no match Patch Set 1:
Your CL relies on deprecated CQ feature(s):
* Private CLs will soon be rejected by CQ (except in Dry Run).
Please, change your CL visibility before submitting to CQ.
For more details, see  https://crbug.com/863631  stamp 2018-08-08 22:42:08+00:00 


D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:570] no match Patch Set 1:
Your CL relies on deprecated CQ feature(s):
* Private CLs will soon be rejected by CQ (except in Dry Run).
Please, change your CL visibility before submitting to CQ.
For more details, see  https://crbug.com/863631  stamp 2018-08-08 22:42:16+00:00 


D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:570] no match Patch Set 1:
Your CL relies on deprecated CQ feature(s):
* Private CLs will soon be rejected by CQ (except in Dry Run).
Please, change your CL visibility before submitting to CQ.
For more details, see  https://crbug.com/863631  stamp 2018-08-08 22:42:37+00:00 


D  [pid:13024 tid:140143373502272 infra_internal.services.cq.pending_manager.gerrit:571] not yet found. Let's post! 

 
Blocking: 863631
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/08e41a58f7e40b0d38f8522db9410a5d88f72554

commit 08e41a58f7e40b0d38f8522db9410a5d88f72554
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Wed Aug 08 22:55:58 2018

Status: Started (was: Assigned)
Oh, CQ gerrit tests were broken, cleanup: https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/661043

And actual fix for problem at hand: https://chrome-internal-review.googlesource.com/c/infra/infra_internal/+/661046
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/2c0b758d82aa1bf714b430590e42ee3ca5fd7ecd

commit 2c0b758d82aa1bf714b430590e42ee3ca5fd7ecd
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Thu Aug 09 19:56:25 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/d26c7fc6b32255a152e8702121c8b936dd992603

commit d26c7fc6b32255a152e8702121c8b936dd992603
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Aug 10 00:45:14 2018

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal/+/ed93fc6f3b0cc06a6d0e6db46308cfda2d03f7f0

commit ed93fc6f3b0cc06a6d0e6db46308cfda2d03f7f0
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Aug 10 00:53:05 2018

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/18accdc24366451d64c1b0a76cd0b981131089c5

commit 18accdc24366451d64c1b0a76cd0b981131089c5
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Aug 10 01:04:35 2018

Sign in to add a comment