New issue
Advanced search Search tips

Issue 872489 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Media Intent Handler: Show entire content:// uri

Project Member Reported by steimel@chromium.org, Aug 8

Issue description

When opening a file in the media intent handler, only "content:" is shown instead of the entire uri. This looks buggy and we should instead show the uri.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b1e4a6e9d46419995f13a14af6bf7ee17f67866

commit 4b1e4a6e9d46419995f13a14af6bf7ee17f67866
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Aug 09 22:31:44 2018

[Media Intent Handler] Show entire content:// URI

This CL adds content:// to the list of schemes that the UrlBar should
display completely. This fixes an issue with the media intent handler
where only "content:" was shown as the url, which looked buggy.

Bug:  872489 
Change-Id: I4af4bf01df1b62738df2023ebb633b4674562b86
Reviewed-on: https://chromium-review.googlesource.com/1168383
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581927}
[modify] https://crrev.com/4b1e4a6e9d46419995f13a14af6bf7ee17f67866/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarData.java

Labels: Merge-Request-69
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 13

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 13

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0e6ac2c55a04f03a2958be457da9b5bd56fc26c

commit d0e6ac2c55a04f03a2958be457da9b5bd56fc26c
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Aug 13 20:28:36 2018

[Media Intent Handler] Show entire content:// URI

This CL adds content:// to the list of schemes that the UrlBar should
display completely. This fixes an issue with the media intent handler
where only "content:" was shown as the url, which looked buggy.

Bug:  872489 
Change-Id: I4af4bf01df1b62738df2023ebb633b4674562b86
Reviewed-on: https://chromium-review.googlesource.com/1168383
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581927}(cherry picked from commit 4b1e4a6e9d46419995f13a14af6bf7ee17f67866)
Reviewed-on: https://chromium-review.googlesource.com/1173076
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#583}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/d0e6ac2c55a04f03a2958be457da9b5bd56fc26c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarData.java

Sign in to add a comment