New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872483 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: Aug 15
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Build aheads is triggering builds even when there are no available bots

Project Member Reported by robert...@chromium.org, Aug 8 
This results in build aheads remaining pending for a long time.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/931dcbd51bebb9dcac01bdd57e8ca21113948f52

commit 931dcbd51bebb9dcac01bdd57e8ca21113948f52
Author: Roberto Carrillo <robertocn@google.com>
Date: Thu Aug 09 18:44:15 2018

[Findit] Set expiration seconds for build aheads.

This way, build aheads that are triggered on busy bots will not inflate
our max pending try job time metric. Also gives a chance for build
aheads to be triggered on an available bot on the next run of the cron
job.

R=stgao,iannucci,liaoyuke,lijeffrey
BUG= 872483 

Change-Id: I7b4a71d0952232d7b355ab238ddedf4f9c5451b6
Reviewed-on: https://chromium-review.googlesource.com/1168195
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/931dcbd51bebb9dcac01bdd57e8ca21113948f52/appengine/findit/common/waterfall/buildbucket_client.py
[modify] https://crrev.com/931dcbd51bebb9dcac01bdd57e8ca21113948f52/appengine/findit/services/build_ahead.py
[modify] https://crrev.com/931dcbd51bebb9dcac01bdd57e8ca21113948f52/appengine/findit/services/test/build_ahead_test.py

Comment 2 by robert...@chromium.org, Aug 15

Status: Fixed (was: Started)
►

Sign in to add a comment