New issue
Advanced search Search tips

Issue 872481 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocking:
issue 872478



Sign in to add a comment

Suggested thing blacklist -- add ability to disable continue reading

Project Member Reported by newcomer@chromium.org, Aug 8

Issue description

Just make the menu option disable continue reading by utilizing a pref.

In the future this will be implemented using search instead of prefs.
 
Blocking: 872478
Labels: -Restrict-View-Google M-70 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/722b2e29dae7d59d976ab1609d562f6a6b566cbb

commit 722b2e29dae7d59d976ab1609d562f6a6b566cbb
Author: wutao <wutao@chromium.org>
Date: Thu Aug 09 22:22:33 2018

cros: Add pref for Launcher continue reading

This cl adds a pref to turn off Launcher continue reading feature.

Bug: 843839,  872481 
Test: manual.
Change-Id: I46553972af783ebc32cdb7fbab76ae207b9474ba
Reviewed-on: https://chromium-review.googlesource.com/1168733
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581913}
[modify] https://crrev.com/722b2e29dae7d59d976ab1609d562f6a6b566cbb/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/722b2e29dae7d59d976ab1609d562f6a6b566cbb/chrome/browser/ui/app_list/search/app_search_provider.cc
[modify] https://crrev.com/722b2e29dae7d59d976ab1609d562f6a6b566cbb/chrome/common/pref_names.cc
[modify] https://crrev.com/722b2e29dae7d59d976ab1609d562f6a6b566cbb/chrome/common/pref_names.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2476e6fb8ec95511552f036cc55de7cff2d34e1d

commit 2476e6fb8ec95511552f036cc55de7cff2d34e1d
Author: wutao <wutao@chromium.org>
Date: Thu Aug 16 01:20:12 2018

cros: Add a setting for the Launcher's 'Continue Reading' feature.

This cl adds a setting to toggle the Launcher's 'Continue Reading' feature.

Bug: 843839,  872481 
Test: manual.
Change-Id: I071e955194edcdf8f3184668b00f60fd8f2de71c
Reviewed-on: https://chromium-review.googlesource.com/1170317
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583482}
[modify] https://crrev.com/2476e6fb8ec95511552f036cc55de7cff2d34e1d/chrome/app/settings_strings.grdp
[modify] https://crrev.com/2476e6fb8ec95511552f036cc55de7cff2d34e1d/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/2476e6fb8ec95511552f036cc55de7cff2d34e1d/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/2476e6fb8ec95511552f036cc55de7cff2d34e1d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Untriaged)
Added a Setting pref.

Sign in to add a comment