New issue
Advanced search Search tips

Issue 872474 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 872258
Owner:
Closed: Aug 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

linux-chromeos-dbg fails in chromevox_tests

Project Member Reported by afakhry@chromium.org, Aug 8

Issue description

The test BackgroundTest.NavigationEscapesEdit fails (https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7204). The culprit CL was identified as https://chromium-review.googlesource.com/c/chromium/src/+/1166563

Please confirm.
 
I'd also like this confirmed; I have two speculative reverts already, but I think we're still seeing this. Is there a revert for the change in the description?
Actually, I don't see how that could be it. Failures are test ones, not compilation.
My only other theory is if the bot does not do a clean build. The original culprit made a build file change to a boolean flag, results in a copy rule. Different files are copied when the flag is on vs off but neither actually deletes preexisting files on disk.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b

commit 5cddd557ba750e0751d9ea8bed5fcf4d16864e2b
Author: David Tseng <dtseng@chromium.org>
Date: Thu Aug 09 00:00:57 2018

Speculative fix for failing Chromevox tests on chromeos-dbg

NOTRY=true
TBR=avi@chromium.org

Bug:  872474 ,  872258 
Change-Id: I891cb4297476ab14d15878bcebafb109a5c3c60c
Reviewed-on: https://chromium-review.googlesource.com/1168472
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581725}
[modify] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/5cddd557ba750e0751d9ea8bed5fcf4d16864e2b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.html

Mergedinto: 872258
Status: Duplicate (was: Assigned)

Sign in to add a comment