New issue
Advanced search Search tips

Issue 872468 link

Starred by 1 user
Status: Fixed
Owner:
derat@chromium.org
Closed: Aug 9
Cc:
apronin@chromium.org
nya@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Increase default timeout for local Tast tests to work around cryptohome hangs

Project Member Reported by derat@chromium.org, Aug 8 
The default timeout for local Tast tests is currently one minute. We currently sometimes see timeouts or other errors when trying to restart the 'ui' job at the beginning of tests that need to interact with Chrome. This seems to sometimes be caused by unavoidable (?) hangs in cryptohome during routine initialization; see e.g.  issue 860519 .

I'm going to try increasing the default timeout for local tests to two minutes to see if these errors go away. In the common case where initialization isn't needed, tests should still be fast.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/cf64f1556958d7a28193ad18e045846604f8cc09

commit cf64f1556958d7a28193ad18e045846604f8cc09
Author: Daniel Erat <derat@chromium.org>
Date: Thu Aug 09 09:21:30 2018

tast-tests: Increase timeout for restarting ui job.

Increase the chrome package's timeout for restarting the
"ui" Upstart job from 30 seconds to 90 seconds to try to
work around ui-post-stop hangs due to slow-running
"cryptohome --action=pkcs11_terminate" commands.

BUG= chromium:860519 , chromium:872468 
TEST=ui.ChromeLogin still passes

Change-Id: I923de582411c64611cecebcb678c2fbd7d933167
Reviewed-on: https://chromium-review.googlesource.com/1168186
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/cf64f1556958d7a28193ad18e045846604f8cc09/src/chromiumos/tast/local/chrome/chrome.go
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/a977eb6931b89c52554406e2b4cdb913247293c3

commit a977eb6931b89c52554406e2b4cdb913247293c3
Author: Daniel Erat <derat@chromium.org>
Date: Thu Aug 09 09:21:39 2018

tast: Increase default local test timeout to two minutes.

A long-running "cryptohome --action=pkcs11_terminate"
process can sometimes block the ui-post-stop script for an
extended period of time when tests try to restart the "ui"
job. Increase the default timeout for local tests from one
minute to two to try to work around this.

BUG= chromium:860519 , chromium:872468 
TEST=unit tests still pass

Change-Id: I6c6c7578bde586f4154353f0fe25c34896dd0b33
Reviewed-on: https://chromium-review.googlesource.com/1168184
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/a977eb6931b89c52554406e2b4cdb913247293c3/src/chromiumos/tast/bundle/local.go

Comment 3 by derat@chromium.org, Aug 9

Status: Fixed (was: Started)
►

Sign in to add a comment