New issue
Advanced search Search tips

Issue 872462 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 872460



Sign in to add a comment

Add support for streams to new FileWriter API

Project Member Reported by mek@chromium.org, Aug 8

Issue description

The new more modern FileWriter API should support writing RaadableStreams to files.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8d74f84359bd5c9ff91388e94bc6efc8906010b

commit c8d74f84359bd5c9ff91388e94bc6efc8906010b
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Mon Oct 01 06:38:16 2018

Use TraceWrapperV8Reference in ReadableStreamBytesConsumer

ReadableStreamBytesConsumer::reader_ has been a weak reference. This CL
makes it a TraceWrapperV8Reference as it is easier to understand.

Bug:  872462 
Change-Id: I669daa87f854a4eab89810b7bf030fc4796d696b
Reviewed-on: https://chromium-review.googlesource.com/1249281
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595392}
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/bindings/core/v8/v8_wasm_response_extensions.cc
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/blob_bytes_consumer.h
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/body_stream_buffer.cc
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/body_stream_buffer.h
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/bytes_consumer.cc
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/bytes_consumer.h
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/fetch_data_loader.cc
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/fetch_manager.cc
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.cc
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/form_data_bytes_consumer.h
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/readable_stream_bytes_consumer.cc
[modify] https://crrev.com/c8d74f84359bd5c9ff91388e94bc6efc8906010b/third_party/blink/renderer/core/fetch/readable_stream_bytes_consumer.h

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/975798170a17a651cb399bdc030b9991cf2c7b3a

commit 975798170a17a651cb399bdc030b9991cf2c7b3a
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Oct 02 03:12:17 2018

[FileSystem] Add support for passing ReadableStream to write.

Bug:  872462 
Change-Id: I0f20f1c71d3d9aee53a2f875198e1e4b3461d90c
Reviewed-on: https://chromium-review.googlesource.com/1232397
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595711}
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/chrome/browser/sync_file_system/local/syncable_file_system_operation.h
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_system_operation.h
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_system_operation_impl.cc
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_system_operation_impl.h
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_system_operation_runner.cc
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_system_operation_runner.h
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_writer_delegate.cc
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_writer_delegate.h
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_writer_impl.cc
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_writer_impl.h
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/storage/browser/fileapi/file_writer_impl_unittest.cc
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/third_party/WebKit/LayoutTests/fast/filesystem/writable-files/file-writer.html
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/third_party/WebKit/LayoutTests/fast/filesystem/writable-files/resources/test-helpers.js
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/third_party/blink/public/mojom/filesystem/file_writer.mojom
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/third_party/blink/renderer/modules/filesystem/file_system_writer.cc
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/third_party/blink/renderer/modules/filesystem/file_system_writer.h
[modify] https://crrev.com/975798170a17a651cb399bdc030b9991cf2c7b3a/third_party/blink/renderer/modules/filesystem/file_system_writer.idl

Owner: mek@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment