New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 872434 link

Starred by 1 user
Status: WontFix
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Closed: Aug 31
Cc:
yyushkina@chromium.org
pnangunoori@chromium.org
█ sweilun@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

force-ui-direction flag set to RTL mode vs selecting an RTL language work differently

Project Member Reported by yyushkina@chromium.org, Aug 8 
Moving this over from https://bugs.chromium.org/p/chromium/issues/detail?id=871162#c6:

We're noticing some elements on the NTP behave differently when the force-ui-direction flag is set to RTL mode vs selecting an RTL language. I noticed that you added the force-ui-direction flag - is this feature intended to emulate setting an RTL language, or something more than that? Thanks!

If it's meant to emulate setting an RTL language, there may be a bug in how the flag is set up.

Comment 1 by vabr@chromium.org, Aug 28

Owner: yyushkina@chromium.org
Hi, sorry for a late response, I was OOO.

If you are referring to https://chromium.googlesource.com/chromium/src/+/0215a8ef53b8eb8faa446366db61113e6f5941a2, please note that that was a broad change in flags infrastructure, not a change particular to RTL. In fact, I have no expertise in RTL and have not done any significant changes to RTL-related code.

Therefore, sending this back to you for further triaging.

Comment 2 by yyushkina@chromium.org, Aug 30

Owner: ramyan@chromium.org
Ramya - when you have a chance can you try to track down who created the force-ui-direction flag originally?

Comment 3 by vabr@chromium.org, Aug 30 

Looking at https://chromium.googlesource.com/chromium/src/+/49ae7c7da53213681a835f53380f275af4c0a4e4, mgiuca@ could be the person you are looking for.

Comment 4 by yyushkina@chromium.org, Aug 30

Owner: mgiuca@chromium.org
Let's try that :)

Comment 5 by mgiuca@chromium.org, Aug 31

Status: WontFix (was: Assigned)
Hi, I added this flag, yes.

Note that it was never intended to be a full substitute for changing the language to RTL. It's designed to help developers build RTL UI while still working in their native language, but you still need to test in the real language.

There are a number of issues with it, but most importantly, it only works with Views UI. It is not designed to work with web UI (such as the NTP) which would require changes to the Blink rendering engine. Marking as WontFix.

Comment 6 by ramyan@chromium.org, Sep 10 

That's good to know, thanks mgiuca@!

Comment 7 by vabr@chromium.org, Nov 29

Cc: -vabr@chromium.org
►

Sign in to add a comment