Map credentials from SMBCONTEXT not from share path |
|||||
Issue descriptionThe auth callback from samba only includes the first part of the share path so we can't disambiguate multiple mounts under the same share. This enables two things 1) Allows us to mount at an arbitrary depth in a share 2) Allows us to disambiguate which callback corresponds to which mount. Need to; 1) Switch from using smbc_setFunctionAuthData to smbc_setFunctionAuthDataWithContext https://github.com/samba-team/samba/blob/master/source3/include/libsmbclient.h#L843 2) Map the context to a mount id in MountManager 3) Store the credential in MountInfo inside MountManager 4) Make a new GetAuthentication function (see InMemoryCredentialStore for current impl) in MountManager which maps SMBCONTEXT to mount_id to MountInfo.SmbCredential 5) Update the binding to use the new GetAuthentication function 6) Remove the credential store implementation 7) Update various fakes and tests along the way
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7d13ead0149364d736fd383ac3b774e03fbd276a commit 7d13ead0149364d736fd383ac3b774e03fbd276a Author: Jimmy Gong <jimmyxgong@google.com> Date: Tue Aug 14 23:06:38 2018 smbprovider: Replaced smbc_setFunctionAuthData with smbc_setFunctionAuthDataWithContext - Replace smbc_setFunctionAuthData with smbc_setFunctionAuthDataWithContext in samba_interface_impl. - This is a starter code, future CL's will incorporate more changes specific to utilizing smbc_setFunctionAuthDataWithContext. BUG= chromium:872405 TEST=emerges Change-Id: I5427ad945597394cb3ae27631a4339c762cad0da Reviewed-on: https://chromium-review.googlesource.com/1170235 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/7d13ead0149364d736fd383ac3b774e03fbd276a/smbprovider/samba_interface_impl.h [modify] https://crrev.com/7d13ead0149364d736fd383ac3b774e03fbd276a/smbprovider/samba_interface_impl.cc
,
Aug 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c9b0ebabf630382dda6a29800629e623fb1354d7 commit c9b0ebabf630382dda6a29800629e623fb1354d7 Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 24 00:42:59 2018 smbprovider: Add WeakPointer support to MountManager - MountManager now derives from base::SupportsWeakPtr. BUG= chromium:872405 TEST=emerges Change-Id: Ib580edd6f201ba8cea73f5a08991bafb88ad921f Reviewed-on: https://chromium-review.googlesource.com/1175405 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/c9b0ebabf630382dda6a29800629e623fb1354d7/smbprovider/mount_manager.h
,
Aug 28
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b2bc91ecf7689a677c01d03a2f6a85bb63a05a97 commit b2bc91ecf7689a677c01d03a2f6a85bb63a05a97 Author: Jimmy Gong <jimmyxgong@google.com> Date: Wed Aug 29 18:15:56 2018 smbprovider: Add GetAuthentication() to MountManager - Adds GetAuthentication() to MountManager. Has no impact on anything and is only preparation code for the removal of CredentialStore. BUG= chromium:872405 TEST=emerges Change-Id: I8ff8da4ef456dc3b6fe1c40c533a295726429e87 Reviewed-on: https://chromium-review.googlesource.com/1175406 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> [modify] https://crrev.com/b2bc91ecf7689a677c01d03a2f6a85bb63a05a97/smbprovider/mount_manager.cc [modify] https://crrev.com/b2bc91ecf7689a677c01d03a2f6a85bb63a05a97/smbprovider/mount_manager.h
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2461291deabc16354c99f6d50b68eb9953a9490e commit 2461291deabc16354c99f6d50b68eb9953a9490e Author: Jimmy Gong <jimmyxgong@google.com> Date: Wed Aug 29 23:08:56 2018 smbprovider: Switch logic from InMemoryCredentialStore to MountManager - MountManager now holds the responsibility of GetAuthentication. - Adds a helper function for MountManager to run its interface factory. - Adjusts SmbProviderDaemon to allow MountManager to use GetAuthentication. - Adjusts SmbProvider Test and MountManager Test to support changes to SambaInterfaceFactoryFunction. BUG= chromium:872405 TEST=emerge Change-Id: I3c5924e358f61c5920ea2118f5eb927d86e25a33 Reviewed-on: https://chromium-review.googlesource.com/1175407 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> [modify] https://crrev.com/2461291deabc16354c99f6d50b68eb9953a9490e/smbprovider/mount_manager.cc [modify] https://crrev.com/2461291deabc16354c99f6d50b68eb9953a9490e/smbprovider/mount_manager.h [modify] https://crrev.com/2461291deabc16354c99f6d50b68eb9953a9490e/smbprovider/mount_manager_test.cc [modify] https://crrev.com/2461291deabc16354c99f6d50b68eb9953a9490e/smbprovider/smbprovider_main.cc [modify] https://crrev.com/2461291deabc16354c99f6d50b68eb9953a9490e/smbprovider/smbprovider_test.cc
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/1e1d50078f1b7dfa77da7090d48298712e7302ef commit 1e1d50078f1b7dfa77da7090d48298712e7302ef Author: Jimmy Gong <jimmyxgong@google.com> Date: Wed Aug 29 23:08:57 2018 smbprovider: Rename SmbCredentials to SmbCredential - Renames struct SmbCredentials to SmbCredential. - Renames 'Credentials' to 'Credential' for consistency. - Fixes any related calls that uses SmbCredentials. BUG= chromium:872405 TEST=emerge Change-Id: Ia92ed6fb50f4038941ae10fb0a689629265bc77a Reviewed-on: https://chromium-review.googlesource.com/1179229 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/mount_manager.cc [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/in_memory_credential_store.cc [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/smbprovider.cc [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/mount_manager_test.cc [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/smbprovider.h [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/credential_store.cc [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/credential_store.h [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/in_memory_credential_store_test.cc [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/kerberos_artifact_client_interface.h [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/mount_manager.h [modify] https://crrev.com/1e1d50078f1b7dfa77da7090d48298712e7302ef/smbprovider/in_memory_credential_store.h
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3b9ba797195fa2062a781ebc18f7e08f482e5fdd commit 3b9ba797195fa2062a781ebc18f7e08f482e5fdd Author: Jimmy Gong <jimmyxgong@google.com> Date: Thu Aug 30 04:05:37 2018 smbprovider: Move SmbCredential to its own file - Creates a new file for the struct SmbCredential. - Remove struct SmbCredential from CredentialStore. BUG= chromium:872405 TEST=emerges Change-Id: I2b83e931097ae81e6c78a95d05ba62d554ae38ed Reviewed-on: https://chromium-review.googlesource.com/1178962 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/3b9ba797195fa2062a781ebc18f7e08f482e5fdd/smbprovider/credential_store.cc [modify] https://crrev.com/3b9ba797195fa2062a781ebc18f7e08f482e5fdd/smbprovider/credential_store.h [modify] https://crrev.com/3b9ba797195fa2062a781ebc18f7e08f482e5fdd/smbprovider/in_memory_credential_store.cc [add] https://crrev.com/3b9ba797195fa2062a781ebc18f7e08f482e5fdd/smbprovider/smb_credential.h
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2115cbc6dc013d8fb5f8e77d5f04e46c2de6aae3 commit 2115cbc6dc013d8fb5f8e77d5f04e46c2de6aae3 Author: Jimmy Gong <jimmyxgong@google.com> Date: Thu Aug 30 04:05:37 2018 smbprovider: Add SambaInterfaceId to AuthCallback - Add parameter SambaInterfaceId to AuthCallback in SambaInterfaceImpl. - Modifies MountManager's GetAuthentication to include SambaInterfaceId. - No functionality added, this is a step before using SambaInterfaceId formally. BUG= chromium:872405 TEST=emerges Change-Id: I25d30acc1fa6296dd185d31525b29c7cc7e2cd0c Reviewed-on: https://chromium-review.googlesource.com/1179302 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/2115cbc6dc013d8fb5f8e77d5f04e46c2de6aae3/smbprovider/mount_manager.cc [modify] https://crrev.com/2115cbc6dc013d8fb5f8e77d5f04e46c2de6aae3/smbprovider/mount_manager.h [modify] https://crrev.com/2115cbc6dc013d8fb5f8e77d5f04e46c2de6aae3/smbprovider/samba_interface_impl.h [modify] https://crrev.com/2115cbc6dc013d8fb5f8e77d5f04e46c2de6aae3/smbprovider/samba_interface.h [modify] https://crrev.com/2115cbc6dc013d8fb5f8e77d5f04e46c2de6aae3/smbprovider/samba_interface_impl.cc
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a9fc714dc13a934be41d8ee1dcbf3e6ebf262133 commit a9fc714dc13a934be41d8ee1dcbf3e6ebf262133 Author: Jimmy Gong <jimmyxgong@google.com> Date: Thu Aug 30 04:05:38 2018 smbprovider: Add unordered_map from SambaInterfaceId to MountId - Adds SambaInterfaceId as uintptr_t in SambaInterface. - Adds unordered_map with key(SambaInterfaceId) to MountId(int32_t). - No functionality, will implement using the map in future CL. BUG= chromium:872405 TEST=emerges Change-Id: Ia1024bd3aa8f36952abd8f6db5358374c0d48e13 Reviewed-on: https://chromium-review.googlesource.com/1184386 Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/a9fc714dc13a934be41d8ee1dcbf3e6ebf262133/smbprovider/mount_manager.h
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a5b49da43be80fc25b6dd58a04f8aba1d4af75fa commit a5b49da43be80fc25b6dd58a04f8aba1d4af75fa Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:39 2018 smbprovider: Change CredentialStore::AddCredential parameter to SmbCredential - Changes parameters of AddCredential in CredentialStore to use SmbCredential. - Added paramter (SmbCredential) to MountInfo. Is not used yet, will be used in future CL's. BUG= chromium:872405 TEST=emerges Change-Id: I3d6a04a620052a6515d20eca70340c0c9f3d6781 Reviewed-on: https://chromium-review.googlesource.com/1182005 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/a5b49da43be80fc25b6dd58a04f8aba1d4af75fa/smbprovider/credential_store.h [modify] https://crrev.com/a5b49da43be80fc25b6dd58a04f8aba1d4af75fa/smbprovider/in_memory_credential_store.cc [modify] https://crrev.com/a5b49da43be80fc25b6dd58a04f8aba1d4af75fa/smbprovider/in_memory_credential_store.h [modify] https://crrev.com/a5b49da43be80fc25b6dd58a04f8aba1d4af75fa/smbprovider/in_memory_credential_store_test.cc [modify] https://crrev.com/a5b49da43be80fc25b6dd58a04f8aba1d4af75fa/smbprovider/mount_manager.cc
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6298653441cf5eb48ceb5544fc4ee77beefde00c commit 6298653441cf5eb48ceb5544fc4ee77beefde00c Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:40 2018 smbprovider: Add SmbCredential to MountInfo - Adds SmbCredential to MountInfo's struct. BUG= chromium:872405 TEST=emerges Change-Id: I55d37bdbe342cb8ee48e4568050f73a0bb4fb4b4 Reviewed-on: https://chromium-review.googlesource.com/1182800 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/6298653441cf5eb48ceb5544fc4ee77beefde00c/smbprovider/mount_manager.cc [modify] https://crrev.com/6298653441cf5eb48ceb5544fc4ee77beefde00c/smbprovider/mount_manager.h [modify] https://crrev.com/6298653441cf5eb48ceb5544fc4ee77beefde00c/smbprovider/smb_credential.h
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/425d2f96394b43fbf19d51c5c987841a4d7f797c commit 425d2f96394b43fbf19d51c5c987841a4d7f797c Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:40 2018 smbprovider: Implement GetSambaInterfaceId() - Adds helper method to MountManager to get the SambaInterfaceId of the system_samba_interface. - Adds GetSambaInterfaceId() to FakeSambaInterface and FakeSambaProxy. BUG= chromium:872405 TEST=emerges Change-Id: I3955548472026377ad6ec497a89aeda72f429a21 Reviewed-on: https://chromium-review.googlesource.com/1184387 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/fake_samba_proxy.cc [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/mount_manager.cc [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/fake_samba_proxy.h [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/fake_samba_interface.cc [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/samba_interface.h [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/samba_interface_impl.cc [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/fake_samba_interface.h [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/mount_manager.h [modify] https://crrev.com/425d2f96394b43fbf19d51c5c987841a4d7f797c/smbprovider/samba_interface_impl.h
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/be3a2c17cd7e03052fc0c11a1fc7b0f65d50c81c commit be3a2c17cd7e03052fc0c11a1fc7b0f65d50c81c Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:41 2018 smbprovider: Add/Remove mounts from samba_interface_map_ - Implements inserting SambaInterfaceId as key mapped to mountId in an unordered_map. - Implements erasing of SambaInterfaceId => MountId in RemoveMount. - Adds helper functions to handle adding/deleting items in samba_interface_map_. - Adds helper functions to get SambaInterfaceId from MountId. BUG= chromium:872405 TEST=emerges Change-Id: I1b707ba3b3d4a42ba8803935b32a185fd821b26a Reviewed-on: https://chromium-review.googlesource.com/1184388 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/be3a2c17cd7e03052fc0c11a1fc7b0f65d50c81c/smbprovider/mount_manager.cc [modify] https://crrev.com/be3a2c17cd7e03052fc0c11a1fc7b0f65d50c81c/smbprovider/mount_manager.h
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8ba3892fd4ef715d49f49d4f1e5cf0b55a1d0ff2 commit 8ba3892fd4ef715d49f49d4f1e5cf0b55a1d0ff2 Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:41 2018 smbprovider: Implement lookup from SambaInterfaceId to MountInfo - Implement double look-up helper function for SambaInterfaceId => MountId => MountInfo BUG= chromium:872405 TEST=emerges Change-Id: I8e5325badd47e08363eb76e5a008590a9b257bd0 Reviewed-on: https://chromium-review.googlesource.com/1184389 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/8ba3892fd4ef715d49f49d4f1e5cf0b55a1d0ff2/smbprovider/mount_manager.cc [modify] https://crrev.com/8ba3892fd4ef715d49f49d4f1e5cf0b55a1d0ff2/smbprovider/mount_manager.h
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3ba23440b5ff6832468a2740070bacdc2e0a5d25 commit 3ba23440b5ff6832468a2740070bacdc2e0a5d25 Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:42 2018 smbprovider: Copy CredentialStore helper functions to MountManager - Copies CredentialStore helper functions to MountManager as private helper functions. - Instead of refactoring the helper functions to a common spot, a copy was necessary because CredentialStore is going to be deleted. BUG= chromium:872405 TEST=emerges Change-Id: I0acceb6d64df8c598f29de6a43aed08d4db8c8a8 Reviewed-on: https://chromium-review.googlesource.com/1186143 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/3ba23440b5ff6832468a2740070bacdc2e0a5d25/smbprovider/mount_manager.cc [modify] https://crrev.com/3ba23440b5ff6832468a2740070bacdc2e0a5d25/smbprovider/mount_manager.h
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5b67c54b97fb2972097432db10fec8cb4a66740c commit 5b67c54b97fb2972097432db10fec8cb4a66740c Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:43 2018 smbprovider: Implement GetAuthentication in MountManager. - Implements GetAuthentication in MountManager. - Updated MountManagerTest to test on new GetAuthentication method. - Removed lingering dependencies of CredentialStore in constructors. BUG= chromium:872405 TEST=verified end-to-end Change-Id: I360179f0cc7e36ea9b92fe94a7ede43243ad243c Reviewed-on: https://chromium-review.googlesource.com/1187740 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/5b67c54b97fb2972097432db10fec8cb4a66740c/smbprovider/mount_manager.cc [modify] https://crrev.com/5b67c54b97fb2972097432db10fec8cb4a66740c/smbprovider/mount_manager.h [modify] https://crrev.com/5b67c54b97fb2972097432db10fec8cb4a66740c/smbprovider/mount_manager_test.cc [modify] https://crrev.com/5b67c54b97fb2972097432db10fec8cb4a66740c/smbprovider/smbprovider_main.cc [modify] https://crrev.com/5b67c54b97fb2972097432db10fec8cb4a66740c/smbprovider/smbprovider_test.cc
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4ef529f160903b2b957f33db5bc054bb0e524cf1 commit 4ef529f160903b2b957f33db5bc054bb0e524cf1 Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Aug 31 12:22:43 2018 smbprovider: Add mounted_share_paths_ to MountManager - mounted_share_paths_ is responsible for keeping track of which share paths have been mounted. - With the future removal of CredentialStore, mounted_share_paths_ will provide a faster (in constant time) and more direct way to check whether a share path has been mounted. BUG= chromium:872405 TEST=emerges Change-Id: I1e40701764b2783f031db2b11d338429272b80ad Reviewed-on: https://chromium-review.googlesource.com/1188786 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/4ef529f160903b2b957f33db5bc054bb0e524cf1/smbprovider/mount_manager.cc [modify] https://crrev.com/4ef529f160903b2b957f33db5bc054bb0e524cf1/smbprovider/mount_manager.h
,
Sep 4
,
Sep 4
Moving to M71. Not all the CL's landed before the branch.
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0af7a44f37c25ba985a7ae3af334660ba692c4f1 commit 0af7a44f37c25ba985a7ae3af334660ba692c4f1 Author: Jimmy Gong <jimmyxgong@google.com> Date: Sat Sep 08 05:27:26 2018 smbprovider: Remove CredentialStore and InMemoryCredentialStore - CredentialStore and InMemoryCredentialStore are both removed. - CredentialStore was an abstract class that was responsible for SmbCredentials and implementation details of GetAuthentication(). - InMemoryCredentialStore was a subclass of CredentialStore whose main responsibility was to store and maintain SmbCredentials. - CredentialStoreTest and InMemoryCredentialStoreTest are also removed. BUG= chromium:872405 TEST=emerge Change-Id: I76a8a5112cbf6c975b10131f197ddd5d4b8ffffd Reviewed-on: https://chromium-review.googlesource.com/1194606 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [delete] https://crrev.com/c2b882a690241ba266d848489ee0b57cb91e6ffc/smbprovider/in_memory_credential_store.cc [modify] https://crrev.com/0af7a44f37c25ba985a7ae3af334660ba692c4f1/smbprovider/smbprovider.gyp [delete] https://crrev.com/c2b882a690241ba266d848489ee0b57cb91e6ffc/smbprovider/credential_store.cc [delete] https://crrev.com/c2b882a690241ba266d848489ee0b57cb91e6ffc/smbprovider/credential_store.h [delete] https://crrev.com/c2b882a690241ba266d848489ee0b57cb91e6ffc/smbprovider/in_memory_credential_store_test.cc [delete] https://crrev.com/c2b882a690241ba266d848489ee0b57cb91e6ffc/smbprovider/in_memory_credential_store.h [delete] https://crrev.com/c2b882a690241ba266d848489ee0b57cb91e6ffc/smbprovider/credential_store_test.cc
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0c303c0fa8d2b0e77abcf2de45d0cf5ee58bdf9c commit 0c303c0fa8d2b0e77abcf2de45d0cf5ee58bdf9c Author: Jimmy Gong <jimmyxgong@google.com> Date: Sat Sep 08 05:27:25 2018 smbprovider: Move GetPassword() to public smbprovider namespace - Moved GetPassword() to public namespace because GetPassword() should have originally been in the public namespace for testing. - Moved GetPassword()'s test cases from CredentialStoreTest to MountManagerTest. - Added additional tests of GetPassword() in MountManagerTest. CQ-DEPEND=CL:1194606 BUG= chromium:872405 TEST=emerge Change-Id: Ie4bced744bf29918dfd731000e23699f40675659 Reviewed-on: https://chromium-review.googlesource.com/1194607 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/0c303c0fa8d2b0e77abcf2de45d0cf5ee58bdf9c/smbprovider/mount_manager.cc [modify] https://crrev.com/0c303c0fa8d2b0e77abcf2de45d0cf5ee58bdf9c/smbprovider/mount_manager.h [modify] https://crrev.com/0c303c0fa8d2b0e77abcf2de45d0cf5ee58bdf9c/smbprovider/mount_manager_test.cc
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/c2b882a690241ba266d848489ee0b57cb91e6ffc commit c2b882a690241ba266d848489ee0b57cb91e6ffc Author: Jimmy Gong <jimmyxgong@google.com> Date: Sat Sep 08 05:27:26 2018 smbprovider: Move InMemoryCredentialTest to MountManagerTest - InMemoryCredentialTest tested on SmbCredentials and will now be moved to MountManagerTest. - InMemoryCredential will be removed in a future CL. BUG= chromium:872405 TEST=unit test Change-Id: I3f658e20b70be2fd828f0a6644d4c67974f874bf Reviewed-on: https://chromium-review.googlesource.com/1198485 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/c2b882a690241ba266d848489ee0b57cb91e6ffc/smbprovider/mount_manager_test.cc
,
Sep 28
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by zentaro@chromium.org
, Aug 8Cc: baileyberro@chromium.org