Auditing Chrome release branches is spamming Monorail |
||||
Issue descriptionSee: https://crbug.com/872348 https://crbug.com/872352 There are at least 10 similar bugs just created in the last couple hours. Going through them, as far as I could see, seem all false-positives, since they were properly approved on the bugs.
,
Aug 8
,
Aug 8
,
Aug 8
We should be getting fewer and few bugs as of late. Unfortunately, we can only test things were they are in production.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5bb0353799c5255f2707fe75e35064733dde4152 commit 5bb0353799c5255f2707fe75e35064733dde4152 Author: Claude <cmasso@google.com> Date: Wed Aug 08 21:27:03 2018 Replace ListIssues with GetIssue RPC Bug:872358 Change-Id: If72c70f8b60723dfe4faa975af14d7e0893689d6 Reviewed-on: https://chromium-review.googlesource.com/1167963 Commit-Queue: Estelle Yomba <cmasso@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/5bb0353799c5255f2707fe75e35064733dde4152/go/src/infra/appengine/cr-audit-commits/app/utils.go [modify] https://crrev.com/5bb0353799c5255f2707fe75e35064733dde4152/go/src/infra/appengine/cr-audit-commits/app/merge_approval_rules.go [modify] https://crrev.com/5bb0353799c5255f2707fe75e35064733dde4152/go/src/infra/appengine/cr-audit-commits/app/merge_approval_rules_test.go
,
Aug 8
The issue I am hitting now is the audit app not able to view security bugs "Found an invalid Monorail bug %!s(int=863069) on relevant commit d8474edf8dc7e6f479937bb67fd191366493315b :: {"error":"unexpected status \"403 Forbidden\". Response: {\"error\": {\"message\": \"User is not allowed to view this issue chromium:863069 \"}}"}"
,
Aug 8
I've talked to Estelle, we can make the rule that is failing set the status to ruleSkipped while we get the audit app permissions to see these bugs.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5502b27883a180bca19e544f8d8e16efe40c2ab8 commit 5502b27883a180bca19e544f8d8e16efe40c2ab8 Author: Claude <cmasso@google.com> Date: Thu Aug 09 17:52:41 2018 Skip auditing commits with security crbugs Bug:872358 Change-Id: I52ef4e6430fecd54a31f3211ec6879eacd4fecb4 Reviewed-on: https://chromium-review.googlesource.com/1168462 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/5502b27883a180bca19e544f8d8e16efe40c2ab8/go/src/infra/appengine/cr-audit-commits/app/merge_approval_rules.go
,
Aug 10
|
||||
►
Sign in to add a comment |
||||
Comment 1 by st...@chromium.org
, Aug 8Labels: -Pri-1 Pri-0
Owner: cma...@chromium.org
Status: Assigned (was: Untriaged)